GNOME Bugzilla – Bug 675870
Implement tablet area cropping/aspect ratio
Last modified: 2012-06-11 14:40:23 UTC
This bug is to implement the g-s-d part for the cropping of tablet area to match output aspect ratio (bug 668907)
Created attachment 213863 [details] [review] Proposed patch This patch add the keep-aspect option to gnome-settings-daemon. When set, it computes the device area to match the assigned monitor aspect ratio. Such an option is incompatible with screen tablets (where it makes no sense), so changing the area to match the output aspect ratio does not interfere with calibration (which is not available for non-screen tablets).
Created attachment 213864 [details] [review] Updated patch Fixed typo in original patch ("!!gsd_wacom_device_is_screen_tablet (device)")
Thinking of it, it would be much better to use the actual monitor size (if available) instead of resolution, as pixels may not be square (or the resolution could be changed by the user).
(In reply to comment #3) > Thinking of it, it would be much better to use the actual monitor size (if > available) instead of resolution, as pixels may not be square (or the > resolution could be changed by the user). Tried that, but that does not work reliably, the monitor is not reporting accurate sizes, so better stick with resolution.
(In reply to comment #4) > (In reply to comment #3) > > Thinking of it, it would be much better to use the actual monitor size (if > > available) instead of resolution, as pixels may not be square (or the > > resolution could be changed by the user). > > Tried that, but that does not work reliably, the monitor is not reporting > accurate sizes, so better stick with resolution. It's good enough in Totem for us to guess the pixel aspect ratio. What problems did you get into?
Review of attachment 213864 [details] [review]: Looks good.
(In reply to comment #5) > It's good enough in Totem for us to guess the pixel aspect ratio. What problems > did you get into? The reported size is not reliable, for example it reported a 23 meters high panel on my laptop (23000mm)... https://bugs.freedesktop.org/show_bug.cgi?id=49911 X devs (ajax and airlied) confirmed that physical display size can't be relied upon.
committed