GNOME Bugzilla – Bug 672947
GtkEntryCompletion sizing/position fixes
Last modified: 2012-05-04 19:44:00 UTC
See attached patches
Created attachment 210722 [details] [review] entry-completion: don't subtract entry borders from popup allocation The completion popup should be aligned with the GtkEntry allocation, not less than that.
Created attachment 210723 [details] [review] entry-completion: set size request on the toplevel window Instead of setting it on the child scrolled window. This is needed because the whole window's allocation must be equal to the one of the entry (in case the popup-set-width property is TRUE); if we set the size request on a children of the window, there might be other children with borders/paddings in between the toplevel and the child we set the size request too, which will break alignment.
Created attachment 210725 [details] web completion with the patch applied
Created attachment 210726 [details] web completion with no patch
Created attachment 210727 [details] web completion with the patch applied Sorry for the noise, I mixed up the screenshots
Review of attachment 210723 [details] [review]: makes sense
Review of attachment 210722 [details] [review]: ok
Attachment 210722 [details] pushed as 644070b - entry-completion: don't subtract entry borders from popup allocation Attachment 210723 [details] pushed as 5a8e2b5 - entry-completion: set size request on the toplevel window