GNOME Bugzilla – Bug 672925
Pictures folder items displayed in random order
Last modified: 2012-08-21 21:00:21 UTC
It is incredibly hard to find stuff in the Pictures folder option of the background settings because they are displayed in random order. I think recent order is much better.
And we should filter out showing screenshots.
or for that matter small images and things that obviously make no sense as wallpapers.
Created attachment 210805 [details] [review] Ignore Screenshots for backgrounds
Created attachment 210806 [details] [review] Sort Pictures folder by name
Created attachment 210812 [details] [review] Ignore Screenshots for backgrounds
Review of attachment 210806 [details] [review]: ::: panels/background/bg-pictures-source.c @@ +198,3 @@ } + cc_background_item_load (item, NULL); What does this do?
(In reply to comment #6) > Review of attachment 210806 [details] [review]: > > ::: panels/background/bg-pictures-source.c > @@ +198,3 @@ > } > > + cc_background_item_load (item, NULL); > > What does this do? calls update_info so we get a valid name. Basically there is no usable metadata until we do that. Pretty unfortunate API I agree.
Review of attachment 210812 [details] [review]: Looks fine for master after branching. ::: panels/background/bg-pictures-source.c @@ +248,3 @@ + create screenshots with the name format + "Screenshot from %s.png" */ + if (g_strrstr (basename, _("Screenshot"))) Why g_strrstr and not strstr?
(In reply to comment #7) > (In reply to comment #6) > > Review of attachment 210806 [details] [review] [details]: > > > > ::: panels/background/bg-pictures-source.c > > @@ +198,3 @@ > > } > > > > + cc_background_item_load (item, NULL); > > > > What does this do? > > calls update_info so we get a valid name. Basically there is no usable metadata > until we do that. Pretty unfortunate API I agree. Looks fine.
> And we should filter out showing screenshots. That’s hilarious. Why did you start to dump them in there in the first place? First you create a potpurri of random images and then you grep them out afterwards again. But you’re right, finding what you need in XDG_PICTURES is a pain. Which makes taking trains of screenshots a pain by inference.
(In reply to comment #10) > > And we should filter out showing screenshots. > > That’s hilarious. This isn't a forum, and I'd be happy if you kept your snarky comments to yourself, especially when I've already commented on the patches.
Review of attachment 210812 [details] [review]: I would actually prefer to filter based on the "software" generating it. See bug 674635
Review of attachment 210806 [details] [review]: Looks fine.
Comment on attachment 210812 [details] [review] Ignore Screenshots for backgrounds commit a3055b3202ca4446f15fa7941c25811a7b4e2f7c Author: Bastien Nocera <hadess@hadess.net> Date: Thu Apr 26 11:07:08 2012 +0100 background: Ignore screenshots Don't list screenshots coming from gnome-screenshot in our Pictures source. https://bugzilla.gnome.org/show_bug.cgi?id=672925
*** Bug 682394 has been marked as a duplicate of this bug. ***