After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671283 - [patch] fixes for vte python bindings
[patch] fixes for vte python bindings
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
0.28.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-04 00:28 UTC by Kevin Fenzi
Modified: 2013-06-21 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Kevin Fenzi 2012-03-04 00:28:02 UTC
Downstream bug: 
https://bugzilla.redhat.com/show_bug.cgi?id=556200

Description of problem:
Calling vt.get_text and passing True for do_attrs causes a segfault, because
the cht variable in build_attributes is never initialized.

Attached is a patch which fixes the bug, and also these other bugs & warnings:

1. Refcounting in call_callback is incorrect; do not decref the callback
function until after it's called.
2. Eliminate signed/unsigned warning in build_attributes; use guint instead of
int.
3. Remove unused count variables from get_text and related functions.  These
were leftover from when the attribute code was duplicated in each.
4. match_check returns a string and an int, but the local variable was declared
as int*.  Change int* tag to int tag.
5. get_text and related methods are written to support callback=NULL, however
the call to PyArg_ParseTupleAndKeywords makes it a required parameter.  Changed
instances of O|OO to |OOO.

Downstream bug has patch.
Comment 1 Christian Persch 2012-03-04 12:21:13 UTC
0.28.x is no longer maintained, and the python bindings were removed in 0.29.x...
Comment 2 Kevin Fenzi 2012-03-05 15:28:22 UTC
Sorry, didn't know 0.28.x is no longer maintained. Feel free to close this out then if thats the case.
Comment 3 Christian Persch 2012-03-08 20:36:33 UTC
If these changes are tested (ie by having been shipped for some time in your rpm) then I guess you could just commit them to vte-0-28 branch, even if no new release is planned. Otherwise, close the bug.
Comment 4 Kevin Fenzi 2012-03-09 21:30:43 UTC
They haven't been shipped yet... but I could toss them in the fedora package and see how they do. 

Since 0.28.x is the last branch that supports gtk2 I think we will be using it a while in fedora.