After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669638 - gtkbuilder-menus: translation-domain can be NULL
gtkbuilder-menus: translation-domain can be NULL
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
unspecified
Other All
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on:
Blocks: 669633
 
 
Reported: 2012-02-08 08:37 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-08 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkbuilder-menus: translation-domain can be NULL (935 bytes, patch)
2012-02-08 08:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:37:44 UTC 
Right now the code is opting out of translating the labels if there's no
translation-domain, d_gettext is perfectly fine with this, so the check
is breaking translations actually.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:37:48 UTC 
Created attachment 207067 [details] [review]
gtkbuilder-menus: translation-domain can be NULL

GtkBuilder defaults its translation-domain to NULL, which is a perfectly
fine value for d_gettext() and friends.
Comment 2 Emmanuele Bassi (:ebassi) 2012-02-08 09:33:09 UTC 
Review of attachment 207067 [details] [review]:

looks good to me
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 09:38:55 UTC 
Done. Thanks.