GNOME Bugzilla – Bug 668091
qtmux: Add support for DASH
Last modified: 2018-11-03 14:45:26 UTC
Created attachment 205444 [details] [review] Add DASH comtaible muxer Dash support for the ISO file format has been defined in the Amendment 3 of the ISO/IEC 14496-12 standard. Basic support can be added by appending the new 'styp', identical to the ftyp box in front of each fragment.
Review of attachment 205444 [details] [review]: ::: gst/isomp4/gstqtmux.c @@ +1539,3 @@ + { + GST_ELEMENT_ERROR (qtmux, STREAM, MUX, (NULL), + ("Failed to serialize ftyp")); s/ftyp/styp/ ::: gst/isomp4/gstqtmuxmap.c @@ +214,3 @@ + "DASH", + "GstDASHMux", + GST_STATIC_CAPS ("video/quicktime, variant = (string) iso-fragmented"), Shouldn't it be a different variant?
Created attachment 252613 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer
Thiago, what do you think?
Review of attachment 252613 [details] [review]: Just a minor nitpicking, otherwise looks good to me. It would be nice to have this early in this cycle so we get proper testing before release. Going to look at the bug for the fragments support in qtmux to get it pushed, too. ::: gst/isomp4/atoms.c @@ -241,2 +241,2 @@ static void -atom_ftyp_init (AtomFTYP * ftyp, guint32 major, guint32 version, GList * brands) +atom_brands_init (AtomFTYP * ftyp, guint32 fourcc, guint32 major, I'd think it is better to rename this to 'AtomBrands' instead of leaving it as AtomFTYP as it can also be an STYP now.
Created attachment 259060 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer
Created attachment 259774 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer
Review of attachment 259774 [details] [review]: Some changelog between the patches would've been good ;) There are now some "qtmux_klass->format != GST_QT_MUX_FORMAT_ISML" cases left that previously also checked for DASH. Why?
Andoni?
Created attachment 343726 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer this updated version of the patch applies on 1.10.2
> this updated version of the patch applies on 1.10.2 Did you not maintain the original Author on that patch on purpose?
sorry, i just did a new git commit and format-patch after merging it
Created attachment 344152 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer Original Credits Andoni Morales Alastruey <ylatuya@gmail.com> this applies on git master aswell
I think you are looking for git commit --amend --author="" :)
Andreas, can you update your patch so that it keeps Andoni as author? We should get this reviewed and merged now.
Created attachment 371663 [details] [review] mp4dashmux: Add DASH-compatible mp4 muxer Remarks: * this is un-re-tested and just a quick resolution of the merge conflict * unit tests will all fail because of a warning caused by G_OBJECT_WARN_INVALID_PROPERTY_ID for the streamable property for unfragmented streams
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/55.