GNOME Bugzilla – Bug 665804
Problems binding and rebinding commands with Caps_Lock and Shift
Last modified: 2011-12-10 14:16:12 UTC
The fix for bug #658122 introduced a regression in which binding commands using OrcaModifier + Shift became generally broken.
http://git.gnome.org/browse/orca/commit/?id=14b3848aea8dba8a23ec5368050be184c3ad8bd9
Joanie, I deleted prewious defined keybindings for Notification message list and toggling indentation and justification, and I try associate this commands with Orca+Shift+semicolon and Orca+Shift+p keystroke with laptop layout. Following configuration values are setted: "enableNotificationMessageListModeHandler": [ [ "semicolon", "365", "8449", "1" ], [ "", "0", "0", "0" ] ], "toggleSpeakingIndentationJustificationHandler": [ [ "p", "365", "8449", "1" ], [ null, null, null, null ] ], When I stored this preferences, I goto learning mode and press this defined keystrokes. Unfortunately nothing happening, Orca doesn't known this keystrokes. Can you reproduce this? Attila
And mine looks quite different with respect to the third item (modifiers): "enableNotificationMessageListModeHandler": [ [ "semicolon", "365", "257", "1" ], [ "", "0", "0", "0" ] ], So I need to figure out why my modifiers (the 257) are different from yours (the 8449). I'm going to try to set up my system with the Hungarian keyboard and see what happens. In the meantime, re-opening.
Heh. That was easier to try than I thought. With the Hungarian layout, I set the alternative keybinding using the same command and wound up with a match. Check it out (the second list): "enableNotificationMessageListModeHandler": [ [ "semicolon", "365", "257", "1" ], [ "semicolon", "365", "8449", "1" ] ], I have a class shortly, but since I can reproduce this issue, I should be able to fix it later today. Thanks for the testing Attila!
Joanie, I don't understand a think: If I associate any script for example my orca-customizations.py file with Orca modifier+Shift+w keystroke, this method is working right. I use following sintax my code: myKeyBindings.add(orca.keybindings.KeyBinding( "w", orca.settings.ORCA_SHIFT_MODIFIER_MASK, orca.settings.ORCA_SHIFT_MODIFIER_MASK, otnaposelorejelzesrovidHandler, 1)) Why working this sintax full right with hungarian keyboard layout, and why have differences the config file the compared modifier masks if I defining a keystroke with Orca preferences dialog /keybindings page? Orca GUI preferences dialog determining different way the keystroke if containing Orca modifier+Shift mask? Attila
Sure by sure I booted now my Precise system and verified my Orca customizations script the example keystroke. The script is proper executed if I using for example the Orca modifier+Shift+w keystroke to ask the five day hungarian weather report condition. After this I verified what value returning when I ask orca.settings.ORCA_SHIFT_MODIFIER_MASK value. The returned value is the proper 257 value. Attila
I just committed an additional fix for this bug to master. It strips out the reserved modifiers which are seen with non-US keyboards. I tested it with Hungarian and Spanish and things are now working as expected for me. Attila, could you please delete the bindings which have the incorrect modifiers, pull master, and re-test? Thanks in advance! http://git.gnome.org/browse/orca/commit/?id=ffd6f349fbd38911bec6f2b24f2ec14fdfbf3bc2
Joanie, I tested the new fix with my Ubuntu Precise system after I deleted the wrong associated keybindings. Every new associated bindings works right. I tested Orca modifier+Shift variations and Orca modifier+CTRL variations. Both two variations working right. Hopefuly after testing time period this fix will be awailable the GNOME 3.2 branch too if this is possible. Attila
Thanks for the testing! Closing as FIXED.