GNOME Bugzilla – Bug 663328
Stop using EmpathyContactListFlags
Last modified: 2011-11-28 11:34:54 UTC
As part of bug #660547 we should get rid of EmpathyContactListFlags
Created attachment 202050 [details] [review] contact-menu: stop using empathy_contact_manager_get_flags_for_connection()
Created attachment 202051 [details] [review] remove empathy_contact_manager_get_flags_for_connection()
Created attachment 202052 [details] [review] tp-contact-list: remove tp_contact_list_get_flags
Created attachment 202053 [details] [review] contact-list: remove flags
Created attachment 202054 [details] [review] add missing empathy-contact-list.h include For some reason, gcc starts complaining about this as soon as I remove EmpathyContactListFlags from empathy-contact-list.h ?! If you have an explanation for this please let me know...
It is a little bit more complex that than unfortunately. 1) CAN_ALIAS should check the AliasFlags on the Aliasing iface. Unfortunately spec predates dbus properties so there is only a GetAliasFlags. Ideally it should be made a property in spec and TpConnection should get it. Otoh it would be the only property so there is no benefit compared to just call GetAliasFlags atm. It would also need an extra feature on TpConnection to introspect I guess... 2) CAN_GROUP should check if groups can be stored. We have tp_connection_get_group_storage() for that.
(In reply to comment #6) > It is a little bit more complex that than unfortunately. > > 1) CAN_ALIAS should check the AliasFlags on the Aliasing iface. Unfortunately > spec predates dbus properties so there is only a GetAliasFlags. Ideally it > should be made a property in spec and TpConnection should get it. Otoh it would > be the only property so there is no benefit compared to just call GetAliasFlags > atm. It would also need an extra feature on TpConnection to introspect I > guess... https://bugs.freedesktop.org/show_bug.cgi?id=28037#c7 > 2) CAN_GROUP should check if groups can be stored. We have > tp_connection_get_group_storage() for that. Fixed.
Created attachment 202278 [details] [review] contact-menu: stop using empathy_contact_manager_get_flags_for_connection()
(In reply to comment #7) > (In reply to comment #6) > > It is a little bit more complex that than unfortunately. > > > > 1) CAN_ALIAS should check the AliasFlags on the Aliasing iface. Unfortunately > > spec predates dbus properties so there is only a GetAliasFlags. Ideally it > > should be made a property in spec and TpConnection should get it. Otoh it would > > be the only property so there is no benefit compared to just call GetAliasFlags > > atm. It would also need an extra feature on TpConnection to introspect I > > guess... > > https://bugs.freedesktop.org/show_bug.cgi?id=28037#c7 Fixed as well. We'll have to depend on the future tp-glib release before merging this.
+1
Attachment 202051 [details] pushed as 79f856c - remove empathy_contact_manager_get_flags_for_connection() Attachment 202052 [details] pushed as b528f95 - tp-contact-list: remove tp_contact_list_get_flags Attachment 202053 [details] pushed as 1cbe27f - contact-list: remove flags Attachment 202054 [details] pushed as 9a353a3 - add missing empathy-contact-list.h include Attachment 202278 [details] pushed as fb2b5ea - contact-menu: stop using empathy_contact_manager_get_flags_for_connection()