GNOME Bugzilla – Bug 663327
Stop using EmpathyContactManager to add and remove contacts
Last modified: 2011-11-08 12:40:46 UTC
This is part of bug #660547
My patches are based on those fixing bug #661805 and are blocked by https://bugs.freedesktop.org/show_bug.cgi?id=42546
Created attachment 200599 [details] [review] client-factory: prepare TP_CONNECTION_FEATURE_CONTACT_LIST_PROPERTIES
Created attachment 200600 [details] [review] add empathy_contact_add_to_contact_list()
Created attachment 200601 [details] [review] contact-search-dialog: stop using EmpathyContactManager
Created attachment 200602 [details] [review] add empathy_contact_remove_from_contact_list()
Created attachment 200603 [details] [review] contact-dialog: stop using EmpathyContactManager
Created attachment 200604 [details] [review] notifications-approver: stop using EmpathyContactManager
Created attachment 200605 [details] [review] contact-list-view: use empathy_contact_remove_from_contact_list()
Review of attachment 200600 [details] [review]: I would add that directly on TpContact tbh. But that can live in Empathy for now, maybe open a tp-glib bug to suggest it?
Looks all good, but we need to announce more publicly that we are making CONTACT_LIST mandatory for Empathy 3.4. Especially since that will prevent butterfly and other python CMs to work (unless someone port them, but unlikely).
(In reply to comment #9) > Review of attachment 200600 [details] [review]: > > I would add that directly on TpContact tbh. But that can live in Empathy for > now, maybe open a tp-glib bug to suggest it? https://bugs.freedesktop.org/show_bug.cgi?id=42595 (In reply to comment #10) > Looks all good, but we need to announce more publicly that we are making > CONTACT_LIST mandatory for Empathy 3.4. Especially since that will prevent > butterfly and other python CMs to work (unless someone port them, but > unlikely). Yeah we should document that in NEWS once it's merged.
Attachment 200599 [details] pushed as 63ec372 - client-factory: prepare TP_CONNECTION_FEATURE_CONTACT_LIST_PROPERTIES Attachment 200600 [details] pushed as b018a11 - add empathy_contact_add_to_contact_list() Attachment 200601 [details] pushed as a8133af - contact-search-dialog: stop using EmpathyContactManager Attachment 200602 [details] pushed as e1cf171 - add empathy_contact_remove_from_contact_list() Attachment 200603 [details] pushed as 6104a6c - contact-dialog: stop using EmpathyContactManager Attachment 200604 [details] pushed as 7457b90 - notifications-approver: stop using EmpathyContactManager Attachment 200605 [details] pushed as 704b05c - contact-list-view: use empathy_contact_remove_from_contact_list()