GNOME Bugzilla – Bug 659272
reset missed counter when viewing messages
Last modified: 2015-02-23 21:44:28 UTC
Created attachment 196756 [details] screenshot When I'm in a chat talking to someone it is really odd to have the missed message counter incrementing. It seems to clear when I leave the chat but it should probably clear when I enter the chat.
I agree. Similarly, for any other notifications, we should reset the counter as soon as I open the summary notification. E.g. if I have missed IRC messages. I'm going to assign it to some OPW applicants, so please consider this bug claimed.
*** Bug 657113 has been marked as a duplicate of this bug. ***
Created attachment 203127 [details] [review] telepathyClient: reset badge as soon as the summary notification is shown That way the user will not see an outdated pending messages count, while they are viewing them or chatting with the sender. https://bugzilla.gnome.org/show_bug.cgi?id=664138
Created attachment 203128 [details] [review] messageTray: display badge only for unseen notifications That way the user will know if there are new notifications related to the source. I am not entirely sure about this patch. Previously, badge counters for non-chat sources were not reset and only indicated the number of notifications associated with the source, if it is greater than one. If we reset the counter upon the notification being seen, we now indicate to the user if the source has unseen notifications, but it's problematic that we don't indicate that in the case there is one unseen notification. Some options are 1) add isStacked flag to IRC, e-mail, and other applications for which unseen notification count makes most sense, and show a badge in case the count is 1 for them too 2) show a badge with count 1 for any unseen non-resident notification. (Showing a badge with count 1 for resident notifications, like Rhythmbox, really doesn't make sense.) That way a badge will uniformly indicate that a source has new notifications. However, this can be annoying as it will create a task for the user to unset the badges. 3) leave things as is for non-chat notifications
Review of attachment 203127 [details] [review]: Extraneous URL in the commit message, extraneous comma in the commit message.
Review of attachment 203128 [details] [review]: Seems fine.
Comment on attachment 203127 [details] [review] telepathyClient: reset badge as soon as the summary notification is shown Leaving the other patch uncommitted for now, waiting for a design review.
Review of attachment 203128 [details] [review]: This needs a refactor if we're going forward with landing bug #643014
Review of attachment 203128 [details] [review]: (dummy comment to shut splinter up)
I'm a little late to the party here but I only just upgraded to gnome-shell 3.4 (go Debian). As you can see in bug #644297 I promoted this behaviour of only acking the messages once the messaging tray has been dismissed (and still only if the channel isn't delegated). I agree with this bug that it makes it look kind of ugly but this behaviour is incredibly useful. For example: Someone writes messages to me: (this screenshot merely shows what has been sent) http://people.collabora.co.uk/~jonny/shellacking1.png The messages are displayed in the shell as usual: http://people.collabora.co.uk/~jonny/shellacking2.png If I now delegate the channel to empathy by clicking on it, now this window appears: http://people.collabora.co.uk/~jonny/shellacking3.png There are two problems here: 1. because the messages have already been acked they don't appear as unread -- I haven't actually included this in the screenshot but in this theme a blue marker appears at the RHS of the message to show it is unread; this is incredibly useful, it's like the red line in xchat-gnome to show where you read up to before. 2. again, because the messages have already been acked they're considered to be old chat, so they are not only greyed out (in this theme) but only five messages are shown. You can see I sent six messages originally. This is possibly a poor example as all the messages are single lined and are simple, so in a way there's no need to delegate it to Empathy. However, long messages which span multiple lines can be hard to read in the messaging tray. Perhaps you're sending your friends more hilarious GList anti-patterns you just found and you paste the code; reading that in Empathy is much more forgiving. Hopefully this use case makes some sense. I do agree that it looks fugly if we ack after the fact though. Can we just give the appearance to have done that though? (Sorry for the essay-long comment.)
We don't have counters with the new notifications design [1], so I think this is obsolete. Please reopen if I'm wrong. [1] https://wiki.gnome.org/Design/OS/Notifications/