After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658785 - online accounts should not connect automatically
online accounts should not connect automatically
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.1.x
Other Linux
: Normal normal
: 3.2
Assigned To: empathy-maint
empathy-maint
: 658945 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-12 06:09 UTC by Blue
Modified: 2011-09-15 07:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
goa-mc-plugin: do not set the ConnectAutomatically Account property (961 bytes, patch)
2011-09-14 10:04 UTC, Guillaume Desmottes
committed Details | Review

Description Blue 2011-09-12 06:09:08 UTC
When using online accounts with gnome-shell... empathy settings are not respected.

The setting 'connect automatically on startup' is not respected at all... by default the online account is automatically logged in after user has unlocked his keyring.

Previous 'status' is not respected.  If user was in 'invisible' mode... online accounts should not automatically force 'available' status.

Online accounts (or gnome-shell) should respect previous states and user settings.
Comment 1 André Klapper 2011-09-12 09:10:15 UTC
Which exact gnome-shell and empathy versions is this about?
Comment 2 Blue 2011-09-12 12:14:50 UTC
Currently I am testing Empathy 3.1.91 with gnome shell 3.1.91... from the [gnome unstable] repositories, Arch Linux.
Comment 3 David Zeuthen (not reading bugmail) 2011-09-12 15:11:20 UTC
I think you are misunderstanding what gnome-online-accounts is about - g-o-a does not in any way enforce any policy or log in to any chat accounts. I think your problem is with empathy. Reassigning.
Comment 4 Guillaume Desmottes 2011-09-13 12:56:28 UTC
What happen exactly? You activate the 'Chat' feature of a GOA account and it doesn't have the same presence as your other accounts?

Or it doesn't connect when you start empathy?

Btw, you can now be online without starting Empathy; just use the new presence picker in Shell's user menu.
Comment 5 Blue 2011-09-13 23:49:48 UTC
Here is a basic rundown:

After activating online accounts, empathy ALWAYS logs in automatically and always into 'Available' status.

I think the integration of empathy is absolutely fantastic.  But, the presence picker should respect user settings.

It should either:

A: Remember what state your online accounts were in last time your username was logged into gnome shell

or

B: Give us the option to NOT log in automatically.  

Empathy provides an option, "Connect Automatically on Startup" that can be toggled off, and that should be respected by the gnome-shell.
Comment 6 Guillaume Desmottes 2011-09-14 09:05:21 UTC
(In reply to comment #5)
> Here is a basic rundown:
> 
> After activating online accounts, empathy ALWAYS logs in automatically and
> always into 'Available' status.

You mean that GOA account are always online when starting the Shell?

> I think the integration of empathy is absolutely fantastic.  But, the presence
> picker should respect user settings.
> 
> It should either:
> 
> A: Remember what state your online accounts were in last time your username was
> logged into gnome shell

Agreed, atm they all should be offline by default, it's weird to have GOA
accounts behaving in a different way. I'll do some tests.
I also opened bug #659021 btw.
Comment 7 Guillaume Desmottes 2011-09-14 10:04:57 UTC
Created attachment 196476 [details] [review]
goa-mc-plugin: do not set the ConnectAutomatically Account property

GOA accounts should behave like regular TP accounts and so shouldn't connect
automatically.
Comment 8 Guillaume Desmottes 2011-09-14 10:15:35 UTC
*** Bug 658961 has been marked as a duplicate of this bug. ***
Comment 9 Ionut Biru 2011-09-14 10:49:31 UTC
*** Bug 658945 has been marked as a duplicate of this bug. ***
Comment 10 Danielle Madeley 2011-09-14 23:05:48 UTC
Review of attachment 196476 [details] [review]:

++
Comment 11 Guillaume Desmottes 2011-09-15 07:34:44 UTC
Attachment 196476 [details] pushed as 0cfae96 - goa-mc-plugin: do not set the ConnectAutomatically Account property