After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657754 - Change (array zero-terminated=1) annotation syntax
Change (array zero-terminated=1) annotation syntax
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-30 19:04 UTC by Daniel Espinosa
Modified: 2015-03-03 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scanner: allow (array zero-terminated) instead of (array zero-terminated=1) (6.09 KB, patch)
2015-02-26 19:20 UTC, Dieter Verfaillie
none Details | Review
scanner: allow (array zero-terminated) instead of (array zero-terminated=1) (17.75 KB, patch)
2015-02-27 20:13 UTC, Dieter Verfaillie
none Details | Review
scanner: allow (array zero-terminated) instead of (array zero-terminated=1) (12.44 KB, patch)
2015-03-01 20:41 UTC, Dieter Verfaillie
accepted-commit_now Details | Review

Description Daniel Espinosa 2011-08-30 19:04:43 UTC
I think is enough to use (array zero-terminated) than the actual syntax.
Comment 1 Colin Walters 2011-08-30 22:44:17 UTC
On the pro side, this would match (transfer foo).  The con is that we're on a slippery slope to "stuff between parenthesis" as our syntax.
Comment 2 André Klapper 2015-02-07 17:15:13 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]
Comment 3 Dieter Verfaillie 2015-02-26 19:20:47 UTC
Created attachment 298025 [details] [review]
scanner: allow (array zero-terminated) instead of (array zero-terminated=1)

Proposed patch because we're already there with "stuff between parenthesis" as our syntax...
Comment 4 Dieter Verfaillie 2015-02-26 21:52:24 UTC
Review of attachment 298025 [details] [review]:

Incomplete and doesn't pass distcheck. Improved patch coming up soon, but not today...
Comment 5 Dieter Verfaillie 2015-02-27 20:13:16 UTC
Created attachment 298130 [details] [review]
scanner: allow (array zero-terminated) instead of (array zero-terminated=1)

Improved version that actually passes distcheck.

What we already had:
- (array zero-terminated=1) > array which is NULL terminated
- (array zero-terminated=0) > array which is not NULL terminated
- (array)                   > array which is not NULL terminated

What this patch adds:
- (array zero-terminated)   > array which is NULL terminated
Comment 6 Dieter Verfaillie 2015-03-01 20:41:21 UTC
Created attachment 298229 [details] [review]
scanner: allow (array zero-terminated) instead of (array zero-terminated=1)

Previous patch mishandled the (array zero-terminated=X) case, where X can be anything. So now it becomes:

What we already had:
- (array zero-terminated=1) > array which is NULL terminated
- (array zero-terminated=0) > array which is not NULL terminated
- (array)                   > array which is not NULL terminated
- (array zero-terminated=X) > array which is not NULL terminated
                   where X can be anything

What this patch adds:
- (array zero-terminated)   > array which is NULL terminated
Comment 7 Colin Walters 2015-03-02 21:11:42 UTC
Review of attachment 298229 [details] [review]:

Looks fine to me.
Comment 8 Dieter Verfaillie 2015-03-03 21:13:47 UTC
(In reply to Colin Walters from comment #7)
> Review of attachment 298229 [details] [review] [review]:
> 
> Looks fine to me.

Pushed as 50dfb46