After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656565 - Signalify (already existing) GtkMenuShell.insert()
Signalify (already existing) GtkMenuShell.insert()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 553204 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-15 12:55 UTC by Allison Karlitskaya (desrt)
Modified: 2013-01-28 23:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Signalify (already existing) GtkMenuShell.insert() (2.46 KB, patch)
2011-08-15 12:55 UTC, Allison Karlitskaya (desrt) 		none Details | Review
Signalify (already existing) GtkMenuShell.insert() (2.46 KB, patch)
2011-08-25 13:49 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
GTK 2.24 backport of 'Signalify (already existing) GtkMenuShell.insert()' (2.49 KB, patch)
2013-01-28 23:01 UTC, fakey 		none Details | Review
Fix the Since: on the GTK 2 insert signal patch (2.49 KB, patch)
2013-01-28 23:20 UTC, fakey 		none Details | Review

Description Allison Karlitskaya (desrt) 2011-08-15 12:55:37 UTC 
We have signal emissions for the equivalent function on GtkContainer so
it seems quite consistent that we should have the same here...
Comment 1 Allison Karlitskaya (desrt) 2011-08-15 12:55:41 UTC 
Created attachment 193863 [details] [review]
Signalify (already existing) GtkMenuShell.insert()

gtk_menu_shell_insert() is a virtual function that was being directly
invoked from the class vtable.

Turn it into a proper signal and emit it in the usual way.
Comment 2 Allison Karlitskaya (desrt) 2011-08-25 13:49:21 UTC 
The following fix has been pushed:
05aeaee Signalify (already existing) GtkMenuShell.insert()
Comment 3 Allison Karlitskaya (desrt) 2011-08-25 13:49:26 UTC 
Created attachment 194701 [details] [review]
Signalify (already existing) GtkMenuShell.insert()

gtk_menu_shell_insert() is a virtual function that was being directly
invoked from the class vtable.

Turn it into a proper signal and emit it in the usual way.
Comment 4 Javier Jardón (IRC: jjardon) 2011-09-09 08:43:35 UTC 
*** Bug 553204 has been marked as a duplicate of this bug. ***
Comment 5 fakey 2013-01-28 04:07:23 UTC 
Is it possible to get this applied to GTK+ 2 as well?
Comment 6 Allison Karlitskaya (desrt) 2013-01-28 15:10:38 UTC 
Can you backport the patch, post it here and test it (perhaps compiling a gtk package for your system and running a bunch of apps against it to make sure everything is OK)?
Comment 7 fakey 2013-01-28 23:01:37 UTC 
Created attachment 234676 [details] [review]
GTK 2.24 backport of 'Signalify (already existing) GtkMenuShell.insert()'

I've tested this with Inkscape, Oregano and the GIMP, as well as in conjunction with a GTK+ module that makes use of the insert signal. Everything worked as expected.
Comment 8 fakey 2013-01-28 23:20:45 UTC 
Created attachment 234678 [details] [review]
Fix the Since: on the GTK 2 insert signal patch

Fix the Since: version.