After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654845 - Move tooltips under pop-up bubbles
Move tooltips under pop-up bubbles
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 649221 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-18 12:28 UTC by Kamil Páral
Modified: 2011-12-22 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bug demonstration (60.46 KB, image/png)
2011-07-18 12:28 UTC, Kamil Páral
  Details
Demonstrates tooltip overlaying text in bubbles (23.27 KB, image/png)
2011-10-17 10:32 UTC, Andre Lohan
  Details
[Dash] Don't show the icon's tooltips when the menu is displayed (#654845). (812 bytes, patch)
2011-12-04 11:20 UTC, Stefano Candori
none Details | Review
[Dash] Don't show the icon's tooltips when the menu is displayed (#654845). (1.25 KB, patch)
2011-12-05 20:05 UTC, Stefano Candori
none Details | Review
New Patch (3.08 KB, patch)
2011-12-14 00:53 UTC, Stefano Candori
none Details | Review
Updated Patch (4.22 KB, patch)
2011-12-14 10:35 UTC, Stefano Candori
none Details | Review

Description Kamil Páral 2011-07-18 12:28:39 UTC
Created attachment 192180 [details]
bug demonstration

Please see attached screenshot. When application name is long and I click right mouse button on the application icon in overview mode, the tooltip saying application name is above the pop-up bubble. That means I can't read some of its text.

The tooltip should probably go away or be placed below the bubble, so that I can read all the text.

There is no easy workaround currently to see the whole text for such applications.

gnome-shell-3.0.2-4.fc15.x86_64
Fedora 15
Comment 1 Andre Lohan 2011-10-17 10:31:38 UTC
Can confirm this here.

gnome-shell 3.2.0
Ubuntu 11.10
Comment 2 Andre Lohan 2011-10-17 10:32:42 UTC
Created attachment 199182 [details]
Demonstrates tooltip overlaying text in bubbles
Comment 3 Kamil Páral 2011-11-15 13:12:12 UTC
Still valid in Gnome 3.2.
Comment 4 Allan Day 2011-11-21 12:34:27 UTC
A better and simpler solution would be to not show the tooltips when the menu is displayed.
Comment 5 Stefano Candori 2011-12-04 11:20:39 UTC
Created attachment 202747 [details] [review]
[Dash] Don't show the icon's tooltips when the menu is displayed (#654845).
Comment 6 Stefano Candori 2011-12-04 11:22:11 UTC
The attached patch fixes the bug using Allan's hint.
Comment 7 Jasper St. Pierre (not reading bugmail) 2011-12-04 17:53:11 UTC
*** Bug 649221 has been marked as a duplicate of this bug. ***
Comment 8 Florian Müllner 2011-12-05 17:36:00 UTC
(In reply to comment #4)
> A better and simpler solution would be to not show the tooltips when the menu
> is displayed.

Note that the current behavior of showing tooltips while the menu is up was done on explicit designer request (https://bugzilla.gnome.org/show_bug.cgi?id=642871#c3). So before moving forward here, I'd like to get some input from Jon.
Comment 9 Stefano Candori 2011-12-05 20:05:01 UTC
Created attachment 202863 [details] [review]
[Dash] Don't show the icon's tooltips when the menu is displayed (#654845).
Comment 10 Stefano Candori 2011-12-05 20:08:42 UTC
With the previous patch there was a problem: the hover highlight disappears once the popup menu shows up. 
I've attached a new patch that fixes this.
Waiting for Jon's input.
Comment 11 Allan Day 2011-12-13 15:56:00 UTC
(In reply to comment #10)
> With the previous patch there was a problem: the hover highlight disappears
> once the popup menu shows up. 
> I've attached a new patch that fixes this.
> Waiting for Jon's input.

I have discussed this with Jon and the other designer types. I think there's general agreement that we should hide the tooltips when the menu is open.

I've also tried your patch, which definitely fixes the bug. I wonder if we can improve the behaviour a little bit though.

The patch seems to hide the tooltip when you click the application icon. I actually quite like this when you are single clicking the app to launch or switch to it. Unfortunately it does mean that the tooltip disappears long before the menu turns up on a long click, however. A few design recommendations, therefore:

 * On long click, leave the tooltip open after the click begins until just before the menu opens.

 * On short/single click remove the tooltip straight away.

 * When remove the tooltip use a very quick fade out.

Hope that makes sense!
Comment 12 Stefano Candori 2011-12-13 16:59:07 UTC
Allan, i think it makes sense...i'm on it! :)
Comment 13 Stefano Candori 2011-12-14 00:53:33 UTC
Created attachment 203411 [details] [review]
New Patch

This new patch solves the problem that Allan said and improves the tooltip behaviour as proposed.

P.S. I've also added a fade-in animation for the tooltip...tell me if you like it.
Comment 14 Allan Day 2011-12-14 09:31:31 UTC
(In reply to comment #13)
> Created an attachment (id=203411) [details] [review]
> New Patch
> 
> This new patch solves the problem that Allan said and improves the tooltip
> behaviour as proposed.
> 
> P.S. I've also added a fade-in animation for the tooltip...tell me if you like
> it.

Thanks Stefano, this is great! Definitely an improvement. I like the fade in.

The only thing I would suggest is making the fade a bit quicker. 150 worked for me. Oh, and you seem to have attached a diff as opposed to a patch.
Comment 15 Stefano Candori 2011-12-14 10:35:23 UTC
Created attachment 203435 [details] [review]
Updated Patch

Here it is the patch (sorry for the previous diff).
Comment 16 Allan Day 2011-12-16 15:36:13 UTC
(In reply to comment #15)
> Created an attachment (id=203435) [details] [review]
> Updated Patch
> 
> Here it is the patch (sorry for the previous diff).

It seems that the patch in bug 666166 touches on the same ground as this one.

I've asked its author to ensure that he incorporates the work that has been done here.
Comment 17 Seif Lotfy 2011-12-17 19:14:37 UTC
I can confirm i integrated Cando's concept into bug 666166.
Awesome work as usual Cando :)
Comment 18 Allan Day 2011-12-22 10:33:52 UTC
The patch for bug 666166 has fixed this. Thanks for your work, Cando!