GNOME Bugzilla – Bug 654467
Update Japanese Concepts Guide
Last modified: 2018-06-29 22:59:52 UTC
Created attachment 191806 [details] [review] Japanese Concepts Guide chap 1-4 bodies I update Japanese version of GnuCash Tutorial and Concepts Guide to keep up with English version. I finished chapter 1 to 4, and working on the other chapters.
The figures are too large to be attached. Please download from https://sites.google.com/site/gnucashtranslation/bugid654467
I've tested the patch and I have made a couple of small modifications by correcting a couple of errors outputted by xmllint regarding a couple of tags. I've also changed the dpi of the images to 144 according to [1] in order to get most of them fit in the pdf page properly. I've also encountered a couple of problems: - I can't generate a pdf without deleting the svg figure. Probably there is some kind of problem with the font. - To make a pdf there is the need to download some font (ipaexfont) and put them in ja_JP/ipaexfont folder. We have to investigate if these fonts can be added to the GnuCash repository (licence compatibility) because otherwise the automatic build of the Japanese documentation will fail. By the way, thanks for contributing
Hello, Thank you for your reviewing my files. > correcting a couple of errors outputted by xmllint regarding a couple of tags. I'll check xml files by "xmllint --noout --valid gnucash-docs.xml" before I submit paches. You may correct <enver> in ch_oview.xml, may you? > I've also changed the dpi of the images to 144 I was troubled because I was not able to solve this the image width problem. I only have to change the resolution of images. I'll set it before sending images next time. > - I can't generate a pdf without deleting the svg figure. Probably there is > some kind of problem with the font. I partly solve this svg import problem. But fop won't use Japanese font at an external SVG file. It always use Times Roman, and Japanese characters are not displayed properly in PDF. So I think it is better to use a PNG file, instead of a SVG file. > We have to investigate if these fonts can be > added to the GnuCash repository (licence compatibility) because otherwise the > automatic build of the Japanese documentation will fail. It's good! This make build processes easy.
Created attachment 193482 [details] [review] Japanese concepts guide chapter 05-10 patch xmllint reports 2 problems in appendix A and appendix D. I'll fix it in the next patch.
I've committed to rev. 21188 the modifications that affects the xml files and the figures (from both patches). I've corrected a couple of problems xmllint was complaining about except the one in fdlappendix.xml regarding a link to a title. The documentation looks fine under ghelp and the make pdf command works though I can't see Japanese characters. > I was troubled because I was not able to solve this the image width problem. > I only have to change the resolution of images. I'll set it before sending > images next time. About this topic, you can check a little text [1] I've put up on the wiki about how to manage the images dimensions on pdf output. [1] http://wiki.gnucash.org/wiki/Documentation_Update_Instructions#Images_and_screenshots
Comment on attachment 191806 [details] [review] Japanese Concepts Guide chap 1-4 bodies (Changing the status of this patch to get it off of the unreviewed patches list.) As Cristian said, the changes to the xml files have been committed, only the pdf generation part will have to be improved upon.
Created attachment 194893 [details] [review] Japanese concepts guide chapter 11 to appendix patch This patch is for Japanese concepts guide, chapter 11 to appendixes. According to xmllint program, the result of this patch is well-formed. I start to proofread and to take screenshots. When I finish them, I'll attach another patch and screenshots.
Created attachment 194894 [details] [review] Japanese concepts guide chapter 11 to appendix patch I'm sorry. I forgot to update svn tree. This patch is against latest svn trunk.
Comment on attachment 194894 [details] [review] Japanese concepts guide chapter 11 to appendix patch The last patch was committed. Now the only thing pending is the ipaexafont integration. Thanks for your work!
Created attachment 195137 [details] [review] Japanese PDF patch This patch is for creating Japanese PDF files. * Add --with-japanese-fontdir, --with-japanese-mincho-ttf, and --with-japanese-gothic-ttf option to configure.in * Check fop-ttfreader in configure script * Replace hardcoded xsltproc and fop with $(XSLTPROC) and $(FOP) respectivelly in makefiles * Add guide/ja_JP/fop.xconfig.in
Comment on attachment 195137 [details] [review] Japanese PDF patch I've tested the last patch for pdf generation and it works. I want to note that with the --with-japanese-fontdir you have to give the full path to folder and not the relative one because otherwise it will not work. The code is in the repo as of rev. 21224. Thanks for your good work! The generated pdf files are now readable in Japanese.
Created attachment 195287 [details] [review] Japanese PDF relative path and typo fix patch Thank you for pointing out relative path problem. This patch is for fixing this problem and some typos.
Created attachment 195289 [details] [review] Japanese PDF relative path and typo fix patch I'm sorry. The patch that I uploaded is invalid. This patch is correct.
Comment on attachment 195289 [details] [review] Japanese PDF relative path and typo fix patch That was fast! Thanks again Yasuaki. The patch is in the repo and works great.
I will wait to close this bug in the event you have some updated images to upload.
Created attachment 195565 [details] [review] Japanese guide proofreading patch This patch is the result of proofreading. You can download updated figures from https://sites.google.com/site/gnucashtranslation/bugid654467 If they are OK, please close this bug. Regards
Comment on attachment 195565 [details] [review] Japanese guide proofreading patch Last patch and figures are committed. Thanks for all your hard work! all Japanese GnuCash users should be thankful for your work. I noticed that some figures goes out of the pdf margin but I'm working on a script that will adapt the dpi based on the image width in order to get rid of this problem once for all.
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=654467. Please update any external references or bookmarks.