Bug 65399 – JS window.open() crashes browser if opened with new tab

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 65399 - JS window.open() crashes browser if opened with new tab


Summary:	JS window.open() crashes browser if opened with new tab


Status:	RESOLVED FIXED

Product:	galeon
Classification:	Deprecated
Component:	Mozilla interaction
Version:	1.0.x
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	Philip Langdale
QA Contact:	Yanko Kaneti

URL:
Whiteboard:

Duplicates:	65608 65696 65777 65914 65915 65960 66077 66102 66182 66699 67017 67021 (view as bug list)
Depends on:
Blocks:

Reported:	2001-11-26 14:50 UTC by Brent R. Matzelle
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Brent R. Matzelle 2001-11-26 14:50:18 UTC

I attempted to open the "Printer-Friendly Version" on the supplied URL in as a new tab but it 
ran a JavaScript window.open() routine that crashed the browser.

Comment 1 Yanko Kaneti 2001-11-26 15:35:32 UTC

here is the backtrace:  (i cnt make that crash in TestGtkEmbed so i
guess its our new embed setup that renders this broken)

Program received signal SIGSEGV, Segmentation fault.
0x40fa8b0d in js_EmitTree () from /usr/lib/libmozjs.so
(gdb) bt

+ Trace 14103

#0 js_EmitTree
from /usr/lib/libmozjs.so
#1 js_EmitTree
from /usr/lib/libmozjs.so
#2 js_EmitTree
from /usr/lib/libmozjs.so
#3 js_CompileFunctionBody
from /usr/lib/libmozjs.so
#4 js_CompileTokenStream
from /usr/lib/libmozjs.so
#5 JS_DefineFunction
from /usr/lib/libmozjs.so
#6 JS_CompileUCScriptForPrincipals
from /usr/lib/libmozjs.so
#7 JS_EvaluateUCScriptForPrincipals
from /usr/lib/libmozjs.so
#8 NSGetModule
from /usr/lib/mozilla/components/libjsdom.so
#9 NSGetModule
from /usr/lib/mozilla/components/libjsurl.so
#10 NSGetModule
from /usr/lib/mozilla/components/libjsurl.so
#11 NSGetModule
from /usr/lib/mozilla/components/liburiloader.so
#12 NSGetModule
from /usr/lib/mozilla/components/liburiloader.so
#13 NSGetModule
from /usr/lib/mozilla/components/liburiloader.so
#14 NSGetModule
from /usr/lib/mozilla/components/libdocshell.so
#15 NSGetModule
from /usr/lib/mozilla/components/libdocshell.so
#16 NSGetModule
from /usr/lib/mozilla/components/libdocshell.so
#17 NSGetModule
from /usr/lib/mozilla/components/libdocshell.so
#18 NSGetModule
from /usr/lib/mozilla/components/libdocshell.so
#19 NSGetModule
from /usr/lib/mozilla/components/libwebbrwsr.so
#20 EmbedPrivate::LoadCurrentURI
from /usr/lib/libgtkembedmoz.so
#21 gtk_moz_embed_load_url
from /usr/lib/libgtkembedmoz.so
#22 embed_load_url
#23 mozembed_load_finished_cb
at mozcallbacks.c line 358
#24 gtk_marshal_NONE__NONE
at gtkmarshal.c line 312

Comment 2 Yanko Kaneti 2001-11-30 02:57:36 UTC

*** Bug 65777 has been marked as a duplicate of this bug. ***

Comment 3 Yanko Kaneti 2001-11-30 03:07:13 UTC

*** Bug 65608 has been marked as a duplicate of this bug. ***

Comment 4 Yanko Kaneti 2001-11-30 03:07:23 UTC

*** Bug 65696 has been marked as a duplicate of this bug. ***

Comment 5 Yanko Kaneti 2001-11-30 03:08:12 UTC

looking at the duplicates it sometimes crashes , sometimes goes into
an infinte window opening loop, pretty sure its the same

Comment 6 Yanko Kaneti 2001-12-01 21:32:05 UTC

*** Bug 65915 has been marked as a duplicate of this bug. ***

Comment 7 Yanko Kaneti 2001-12-01 21:32:22 UTC

*** Bug 65914 has been marked as a duplicate of this bug. ***

Comment 8 Yanko Kaneti 2001-12-02 18:57:17 UTC

*** Bug 65960 has been marked as a duplicate of this bug. ***

Comment 9 Yanko Kaneti 2001-12-03 00:29:38 UTC

ok i've put a hacky workaround this in both stable and head

it should really be rethought  in HEAD

Comment 10 Marco Pesenti Gritti 2001-12-03 09:40:45 UTC

Can you please explain how it should be retought ?
I mean, what is the behavior you think we should have and if it 
should be fixed in galeon or mozilla. Thank you.

Comment 11 Yanko Kaneti 2001-12-03 15:38:05 UTC

ahm, i am sorry for the blanket statement

its just that this is a workaround and i am not curently sure what is
the correct way of fixing it

we are not sure if a certain url handling by mozilla would produce a
new window/tab by default (js window.open, url download handlers, othe
urls we dont know anything about)

so effectively we cannot control the interface to dissalow
inappropriate requests, like  in this case js window.open in a new
window/tab, or   open a tar.gz in  new window tab, which curently
produces a blank new window and a downloader request

does this mean the embed management should be left to gtkmozembed and
we should only create new embeds on request by it? 

i dont know, just braindumping

Comment 12 Yanko Kaneti 2001-12-04 22:45:26 UTC

*** Bug 66077 has been marked as a duplicate of this bug. ***

Comment 13 Yanko Kaneti 2001-12-04 23:32:21 UTC

*** Bug 66182 has been marked as a duplicate of this bug. ***

Comment 14 Yanko Kaneti 2001-12-04 23:34:15 UTC

*** Bug 66187 has been marked as a duplicate of this bug. ***

Comment 15 Yanko Kaneti 2001-12-11 08:47:38 UTC

*** Bug 66699 has been marked as a duplicate of this bug. ***

Comment 16 Yanko Kaneti 2001-12-16 11:16:04 UTC

*** Bug 67017 has been marked as a duplicate of this bug. ***

Comment 17 Yanko Kaneti 2001-12-16 11:16:30 UTC

*** Bug 67021 has been marked as a duplicate of this bug. ***

Comment 18 Yanko Kaneti 2002-01-21 17:16:57 UTC

*** Bug 66102 has been marked as a duplicate of this bug. ***

Comment 19 Bugzilla Maintainers 2004-04-01 23:44:57 UTC

The URL field has been removed from bugzilla.gnome.org. This URL was in the old URL field, and is being added as a comment so that the data is not lost. Please email bugmaster@gnome.org if you have any questions.

URL: 
http://www.businessweek.com/careers/content/aug2000/ca20000811_855.htm