After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652798 - kill AtkMisc
kill AtkMisc
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on: 652797
Blocks:
 
 
Reported: 2011-06-17 03:10 UTC by Matthias Clasen
Modified: 2013-12-11 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2011-06-17 03:10:31 UTC
Its sole purpose in life was to break the gdk lock, so
getting rid of it would make me sleep a lot better. There is still a use of atk_misc_get_instance() in at-spi2-atk, but it is not actually used anymore there.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-06-17 12:32:07 UTC
Well, I only see a problem here. Although at-spi was declared dead a lot of times, the truth is that most distributions are using it. And at-spi is still using the undocumented AtkMisc.

Should we definitively declare deprecated and unmaintained at-spi, doesn't care at all for my concerns on my first paragrah, remove AtkMisc, and going forward improving Atk? For me yes.

Of course, the middle term solution is declare it as deprecated, and totally remove it at ATK 3.0.

Li, what do you think?
Comment 2 Matthias Clasen 2011-06-17 18:21:42 UTC
Just to be clear, if anything uses AtkMisc inside the application (I know that atk-bridge used to do this in the past), then multithreaded applications just break. Rhythmbox has tons of segfaults reported which come ultimatively from a11y being turned on, which breaks the protection provided by the GDK lock for using GTK from multiple threads.
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-06-20 09:39:20 UTC
(In reply to comment #2)
> Just to be clear, if anything uses AtkMisc inside the application (I know that
> atk-bridge used to do this in the past), 

As I said, atk-bridge from at-spi (CORBA one) is using it, in the present.

> then multithreaded applications just
> break. Rhythmbox has tons of segfaults reported which come ultimatively from
> a11y being turned on, which breaks the protection provided by the GDK lock for
> using GTK from multiple threads.

As I said I also think that this should be removed. So again, the conservative option would be mark atkmisc as deprecated (with a really big WARNING ATCHUNG! WARNING) when explaining why not use it, so distros still using at-spi could still compile it. We could definitively remove it in the future.
Comment 4 André Klapper 2011-06-23 22:05:34 UTC
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 .
PLEASE NOTE:
If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla.
Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-12-11 11:54:03 UTC
Marked as deprecated and improved the documentation to clearly state that with this commit:
https://git.gnome.org/browse/atk/commit/?id=11ba48d7b03bf9324864effcd077cd844ba388a1

Closing bug.