After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652730 - workspaces-display: Don't slide out pager on drag-begin
workspaces-display: Don't slide out pager on drag-begin
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 652714
Blocks:
 
 
Reported: 2011-06-16 13:10 UTC by Florian Müllner
Modified: 2011-06-27 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspaces-display: Don't slide out pager on drag-begin (1.94 KB, patch)
2011-06-16 13:10 UTC, Florian Müllner
committed Details | Review
dnd: Rename DND.removeMonitor() to DND.removeDragMonitor() (2.23 KB, patch)
2011-06-27 17:08 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-06-16 13:10:21 UTC
Proposed by Jasper on IRC, makes sense to me - see attached patch.
Comment 1 Florian Müllner 2011-06-16 13:10:25 UTC
Created attachment 190042 [details] [review]
workspaces-display: Don't slide out pager on drag-begin

Sliding out the workspaces pager when starting a drag causes a lot
of motion. With the pager only hiding if workspaces are not used,
it is better to require to explicitly hover the workspaces sidebar
for the sliding.
Comment 2 Dan Winship 2011-06-27 13:12:20 UTC
Comment on attachment 190042 [details] [review]
workspaces-display: Don't slide out pager on drag-begin

>+        DND.removeDragMonitor(this._dragMonitor);

the method is apparently named "DND.removeMonitor", but a patch to rename it to match "DND.addDragMonitor" would be better than fixing this call.
Comment 3 Florian Müllner 2011-06-27 17:08:26 UTC
Created attachment 190779 [details] [review]
dnd: Rename DND.removeMonitor() to DND.removeDragMonitor()

DND.addDragMonitor() and DND.removeMonitor() are inconsistently
named, so rename the latter.

(In reply to comment #2)
> (From update of attachment 190042 [details] [review])
> >+        DND.removeDragMonitor(this._dragMonitor);
> 
> the method is apparently named "DND.removeMonitor"

Ugh. No idea how that happened (referring to the original drag monitor patch, not this one ...)
Comment 4 Florian Müllner 2011-06-27 19:39:44 UTC
Attachment 190042 [details] pushed as ed8acef - workspaces-display: Don't slide out pager on drag-begin
Attachment 190779 [details] pushed as 737f395 - dnd: Rename DND.removeMonitor() to DND.removeDragMonitor()