After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652271 - [PATCH] GStreamer.PlayerEngine: Fixed soundmenu song metadata update
[PATCH] GStreamer.PlayerEngine: Fixed soundmenu song metadata update
Status: RESOLVED DUPLICATE of bug 648498
Product: banshee
Classification: Other
Component: Other Extensions
git master
Other Linux
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-10 10:27 UTC by Dinh Ngoc Tu
Modified: 2011-06-10 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for Banshee.GStreamer/PlayerEngine.cs (1.23 KB, patch)
2011-06-10 10:27 UTC, Dinh Ngoc Tu 		none Details | Review

Description Dinh Ngoc Tu 2011-06-10 10:27:21 UTC 
Created attachment 189608 [details] [review]
Patch for Banshee.GStreamer/PlayerEngine.cs

Replication: Add songs to a Play Queue. If you manually select a song, it plays normally. If you let Banshee play the queue automatically while gapless playback is on, the soundmenu will be one song behind.

Original bug: https://bugzilla.gnome.org/show_bug.cgi?id=648498

OnNextTrackStarting() already called OnEventChanged(StartOfStream), but MPRIS won't update the metadata unless you explicitly force it to do so.
This patch fixes that problem by calling OnEventChanged(TrackInfoChanged), forcing the soundmenu to update.

This is my first attempt at contributing, so I am sorry if I did anything wrong.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2011-06-10 10:33:32 UTC 
devper, thanks for your contribution!

Why did you create a new bug?

Can you mark this as duplicate of that one, and attach your patch there? We don't want to deviate the conversation about the issue.
Comment 2 Dinh Ngoc Tu 2011-06-10 10:44:59 UTC 
Yes, I am marking this bug as Duplicate now.

*** This bug has been marked as a duplicate of bug 648498 ***