GNOME Bugzilla – Bug 647733
Add libraw support for loading images
Last modified: 2015-11-16 17:12:44 UTC
Created attachment 185923 [details] [review] rename raw-load to dcraw-load to free it up for libraw In order to support a wider variety of RAW image formats an operation to interface with libraw is preferred over the current libopenraw operation. I've tried multiple times to send this to the mailing list but my emails aren't showing up in the archive. Looking forward to providing more patches in the future.
Created attachment 185924 [details] [review] Add libraw load operation
Created attachment 186157 [details] [review] Libraw load support
I've created a patch to add a test for this operation. Because it includes a raw file it's too large to attach here, but I've uploaded it to google docs. https://docs.google.com/leaf?id=0BxkCj94TA_zOMjNiY2QwYWEtNzliMS00YTg3LWE4YzMtZWM0ZTIyZjA5MTg3&hl=en
I don't think we want a 19 MB file in the GEGL source tree, can you make it smaller and compress it somehow? IANAL but we might also need to add a --enable-gpl switch to configure since libraw is GPLv3
I completely agree that any raw test is going to add a relatively large amount of data to the repository due to the fact that the raw source file itself is going to be large. My camera's raw files are ~12MB. In this case I don't think the benefit of having a test is worthwhile with the size of the patch that's going to be required.
*** Bug 651288 has been marked as a duplicate of this bug. ***
Created attachment 198037 [details] [review] Alternative patch From duplicate bug
I'm sorry that the patches in this bug has managed to sit uncommited for so long, the patches have been brought up to date with current APIs and integrated with GEGL master. commit 73ca89e42f5b0f0290d08be05650f0b86ffe5ec9 Author: Øyvind Kolås <pippin@gimp.org> Date: Mon Jun 8 19:32:52 2015 +0200 openraw: remove in favor of libraw commit f8447e2cebf51d80d76398fa7e91bbcd892a3200 Author: Øyvind Kolås <pippin@gimp.org> Date: Mon Jun 8 19:27:35 2015 +0200 libraw: rewrite from Paul Sbarra A more feature-rich and less glitchy, implementation from Paul Sbarra <tones111@hotmail.com> in bug #647733 commit 0ae4d72520bee8c3324d201fb0514021dc9cf46a Author: Øyvind Kolås <pippin@gimp.org> Date: Mon Jun 8 19:02:11 2015 +0200 raw-load: fix compilation warnings commit 8a77a5548b9ada8e2ff707e9b30b049e3ed114a0 Author: Øyvind Kolås <pippin@gimp.org> Date: Mon Jun 8 18:52:06 2015 +0200 ops: rename raw-load to dcraw-load, and lraw-load to rawload commit 556e8589fe74a281a05f8219eaab4fab29c05753 Author: Øyvind Kolås <pippin@gimp.org> Date: Sat May 23 16:18:40 2015 +0200 add libraw based raw loader op Add a libraw op based on rough cleanup to make the patch in https://bugzilla.gnome.org/show_bug.cgi?id=647733 compile with git master.
*** Bug 743543 has been marked as a duplicate of this bug. ***