After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644951 - Fix translation of New.. and Open...
Fix translation of New.. and Open...
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-16 20:34 UTC by Kjartan Maraas
Modified: 2011-03-17 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix translations (930 bytes, patch)
2011-03-16 20:34 UTC, Kjartan Maraas
none Details | Review
Removing NC_ macros (and also context string) (993 bytes, patch)
2011-03-17 09:49 UTC, Claude Paroz
none Details | Review

Description Kjartan Maraas 2011-03-16 20:34:07 UTC
Created attachment 183569 [details] [review]
patch to fix translations

These strings in the Archive menu aren't properly translated because they are marked with NC_() and the rest of the strings in the array are marked with N_(). According to Claude Paroz one has to use one and only one translation function in each array.

Also, context isn't very important for these two strings anyway, and could be solved with normal translator comments if necessary.

Attaching a patch to just use N_() instead of NC_()
Comment 1 Claude Paroz 2011-03-16 20:48:46 UTC
And as the current strings are untranslated in the interface due to this bug, I would even say that you don't need approval from gnome-i18n to commit (you have mine anyway).
Comment 2 Claude Paroz 2011-03-17 09:49:23 UTC
Created attachment 183611 [details] [review]
Removing NC_ macros (and also context string)
Comment 3 Matthias Clasen 2011-03-17 11:27:54 UTC
Not a blocker
Comment 4 Paolo Bacchilega 2011-03-17 11:49:32 UTC
patch applied to master, thank you.