After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644730 - [matroskamux] Should return TRUE in the event function when the event is handled
[matroskamux] Should return TRUE in the event function when the event is handled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.29
Assigned To: Andoni Morales
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-14 14:39 UTC by Andoni Morales
Modified: 2011-03-14 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-matroskamux-fix-return-value-in-the-event-function-w.patch (1.01 KB, patch)
2011-03-14 14:43 UTC, Andoni Morales
needs-work Details | Review
0001-matroskamux-fix-return-value-in-the-event-function-w.patch (1.01 KB, patch)
2011-03-14 15:39 UTC, Andoni Morales
none Details | Review
0001-matroskamux-fix-return-value-in-the-event-function-w.patch (1.34 KB, patch)
2011-03-14 15:40 UTC, Andoni Morales
committed Details | Review

Description Andoni Morales 2011-03-14 14:39:31 UTC
It should return TRUE in the event function when the event is handled
Comment 1 Andoni Morales 2011-03-14 14:43:48 UTC
Created attachment 183346 [details] [review]
0001-matroskamux-fix-return-value-in-the-event-function-w.patch

And set the event to NULL as a hint to chain up
Comment 2 Tim-Philipp Müller 2011-03-14 15:05:26 UTC
Comment on attachment 183346 [details] [review]
0001-matroskamux-fix-return-value-in-the-event-function-w.patch

What we want to achieve (aiui): current behaviour is maintained, only that we return TRUE for tag events that are not forwarded, because it's been handled.

It looks to me like your patch changes behaviour so that the tag event is now forwarded (if it doesn't crash before that).

"if (ret) chain->up()" should be changed to "if (event) chain->up()". event should also be set to NULL in the newsegment part then.
Comment 3 Andoni Morales 2011-03-14 15:39:04 UTC
Created attachment 183352 [details] [review]
0001-matroskamux-fix-return-value-in-the-event-function-w.patch

You are right. Changed to check "if (event)" an setting "event=NULL" for the NEWSEGMENT .
Comment 4 Andoni Morales 2011-03-14 15:39:48 UTC
upps wrong file
Comment 5 Andoni Morales 2011-03-14 15:40:30 UTC
Created attachment 183353 [details] [review]
0001-matroskamux-fix-return-value-in-the-event-function-w.patch
Comment 6 Tim-Philipp Müller 2011-03-14 17:10:16 UTC
commit 0ed0174ea98923186112458512e5a026ac69716c
Author: Andoni Morales Alastruey <amorales@flumotion.com>
Date:   Mon Mar 14 15:46:50 2011 +0100

    matroskamux: return TRUE from sink pad event function for tag events, which are handled
    
    https://bugzilla.gnome.org/show_bug.cgi?id=644730