GNOME Bugzilla – Bug 641886
Volume should go up to 150%
Last modified: 2011-07-13 19:03:58 UTC
Similarly to bug 602494 (volume applet) and bug 631030 (media-keys). Volume should go up to 150% if the sound card used as output has decibel volume support (eg. if gvc_mixer_stream_get_can_decibel() returns TRUE).
Created attachment 180508 [details] [review] volume: Increase maximum by 50% for outputs with decibel support Volume should go up to 150% if the sound card used as output has decibel volume support.
Created attachment 180509 [details] [review] volume: Increase maximum by 50% for outputs with decibel support Volume should go up to 150% if the sound card used as output has decibel volume support.
Giovanni - can you review this?
Review of attachment 180509 [details] [review]: You also need to modify _mutedChanged and _volumeChanged to use a different proportion, or the slider will look maximized when setting a volume louder than 100% using the media keys.
Created attachment 180720 [details] [review] volume: Increase maximum by 50% for outputs with decibel support Volume should go up to 150% if the sound card used as output has decibel volume support. --- *) Handle _mutedChanged and _volumeChanged too
Created attachment 180722 [details] [review] volume: Increase maximum by 50% for outputs with decibel support Volume should go up to 150% if the sound card used as output has decibel volume support. --- *) Avoid code duplication
Review of attachment 180722 [details] [review]: If get_can_decibel does not change without the stream changing underneath (which recreates the Slider), then this patch should work fine.
(In reply to comment #7) > Review of attachment 180722 [details] [review]: > > If get_can_decibel does not change without the stream changing underneath > (which recreates the Slider), then this patch should work fine. It shouldn't.
Attachment 180722 [details] pushed as bdd805a - volume: Increase maximum by 50% for outputs with decibel support
hi, I'm the owner of a sound card which provides gvc_mixer_stream_get_can_decibel() I'm running gnome-shell 3.0.2 and, as per your patch, the volume slider on the top bar volume goes up to 150% if you bring it to its maximum level (eg. using the mouse scroll) the problem is that when the slider goes past 100% it is actually distorting the sound output the problem has been reported with the bug #649411 ; I think the slider SHOULD NOT go over 100% by default. It is ok to have some overdrive for laptops but we SHOULD NOT distort the sound by default ... while at the moment, after a fresh install, if you ramp up the volume to its maximum level you are actually distorting the output apparently the two bug reports contraddict each other, what I'm asking is: why the colume should go up to 150% if the sound card used as output has decibel volume support (eg. if gvc_mixer_stream_get_can_decibel() returns TRUE). ? thanks for listening