After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641650 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
git master
Other All
: Normal enhancement
: 2.26
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-06 06:48 UTC by Craig Keogh
Modified: 2011-10-21 06:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Honor aclocal flags (564 bytes, patch)
2011-02-06 06:49 UTC, Craig Keogh
committed Details | Review

Description Craig Keogh 2011-02-06 06:48:23 UTC
I'm building brasero via JHBuild. brasero builds
successfully. If upstream then updates configure.in, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/brasero/missing --run aclocal-1.11 
configure.in:286: warning: macro `AM_GLIB_DEFINE_LOCALEDIR' not found in library
configure.in:584: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
 cd . && /bin/sh /home/Oxyde/gnome/brasero/missing --run automake-1.11 --foreign
gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
docs/reference/libbrasero-burn/Makefile.am:120:   `gtk-doc.make' included from here
gtk-doc.make:51: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/libbrasero-burn/Makefile.am:120:   `gtk-doc.make' included from here
gtk-doc.make:52: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL
docs/reference/libbrasero-burn/Makefile.am:120:   `gtk-doc.make' included from here
gtk-doc.make:57: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL
docs/reference/libbrasero-burn/Makefile.am:120:   `gtk-doc.make' included from here
gtk-doc.make:226: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/libbrasero-burn/Makefile.am:120:   `gtk-doc.make' included from here
gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL
docs/reference/libbrasero-media/Makefile.am:117:   `gtk-doc.make' included from here
gtk-doc.make:51: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/libbrasero-media/Makefile.am:117:   `gtk-doc.make' included from here
gtk-doc.make:52: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL
docs/reference/libbrasero-media/Makefile.am:117:   `gtk-doc.make' included from here
gtk-doc.make:57: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL
docs/reference/libbrasero-media/Makefile.am:117:   `gtk-doc.make' included from here
gtk-doc.make:226: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
docs/reference/libbrasero-media/Makefile.am:117:   `gtk-doc.make' included from here
gnome-doc-utils.make:63: HAVE_GNOME_DOC_UTILS does not appear in AM_CONDITIONAL
help/Makefile.am:1:   `gnome-doc-utils.make' included from here
gnome-doc-utils.make:143: ENABLE_SK does not appear in AM_CONDITIONAL
help/Makefile.am:1:   `gnome-doc-utils.make' included from here
gnome-doc-utils.make:192: ENABLE_SK does not appear in AM_CONDITIONAL
help/Makefile.am:1:   `gnome-doc-utils.make' included from here
make: *** [Makefile.in] Error 1
Comment 1 Craig Keogh 2011-02-06 06:49:56 UTC
Created attachment 180210 [details] [review]
Honor aclocal flags
Comment 2 Luis Medinas 2011-08-17 21:32:10 UTC
I can reproduce this bug but i think we should wait for automake 1.12 to fix this issue... this isn't that related to brasero.
Comment 3 Craig Keogh 2011-08-18 10:30:34 UTC
Approximately 79 GNOME modules have this same fix. It is very low risk.
The fix prevents new developers saying 'What is going brasero? It built fine before, now it suddenly stops'
Comment 4 David King 2011-10-21 06:48:04 UTC
Comment on attachment 180210 [details] [review]
Honor aclocal flags

Pushed a modified patch, with a comment that this workaround can be removed when Automake 1.12 is released, to master as commit 1f6c224d4d13b13e13b40781bd4b1d09495a16a2.