Bug 641472 – configure should honor aclocal flags ACLOCAL_FLAGS

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 641472 - configure should honor aclocal flags ACLOCAL_FLAGS


Summary:	configure should honor aclocal flags ACLOCAL_FLAGS


Status:	RESOLVED FIXED

Product:	libgweather
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal enhancement
Target Milestone:	2.22.0
Assigned To:	libgweather-maint
QA Contact:	libgweather-maint

URL:
Whiteboard:

Depends on:
Blocks:	641445

Reported:	2011-02-04 10:28 UTC by Craig Keogh
Modified:	2011-02-04 11:10 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Honor aclocal flags (613 bytes, patch) 2011-02-04 10:29 UTC, Craig Keogh	committed	Details \| Review
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am (943 bytes, patch) 2011-02-04 10:32 UTC, Craig Keogh	committed	Details \| Review

Description Craig Keogh 2011-02-04 10:28:41 UTC

I'm building libgweather via JHBuild. libgweather builds
successfully. If upstream then updates configure.in, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/libgweather/missing --run aclocal-1.11 -I m4
configure.ac:143: warning: macro `AM_GCONF_SOURCE_2' not found in library
configure.ac:146: warning: macro `AM_PATH_GLIB_2_0' not found in library
configure.ac:154: warning: macro `AM_GLIB_GNU_GETTEXT' not found in library
 cd . && /bin/sh /home/Oxyde/gnome/libgweather/missing --run automake-1.11 --gnu
data/Makefile.am:13: `%'-style pattern rules are a GNU make extension
data/Makefile.am:13: wildcard $(top_srcdir: non-POSIX variable name
data/Makefile.am:13: (probably a GNU make extension)
data/Makefile.am:23: shell if test -n "$(LINGUAS: non-POSIX variable name
data/Makefile.am:23: (probably a GNU make extension)
data/Makefile.am:28: shell echo $(PO_LOCATIONS: non-POSIX variable name
data/Makefile.am:28: (probably a GNU make extension)
libgweather/Makefile.am:110: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL
libgweather/Makefile.am:136: GCONF_SCHEMAS_INSTALL does not appear in AM_CONDITIONAL
libgweather/Makefile.am:124: addprefix $(srcdir: non-POSIX variable name
libgweather/Makefile.am:124: (probably a GNU make extension)
po-locations/Makefile.am:1: wildcard *.po: non-POSIX variable name
po-locations/Makefile.am:1: (probably a GNU make extension)
make: *** [Makefile.in] Error 1

Comment 1 Craig Keogh 2011-02-04 10:29:23 UTC

Created attachment 180059 [details] [review]
Honor aclocal flags

Comment 2 Craig Keogh 2011-02-04 10:32:14 UTC

Created attachment 180060 [details] [review]
Remove configure.ac ACLOCAL_FLAGS, now in Makefile.am


This patch removes the ACLOCAL_FLAGS support in configure.ac. ACLOCAL_FLAGS
support is in Makefile.am as per attachment 180059 [details] [review]. See bug 640883 comment 4 by Christian Persch for more information.

Comment 3 Vincent Untz 2011-02-04 11:09:55 UTC

Thanks, I've pushed both patches as one commit, and improved the commit message ;-)