After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641448 - configure should honor aclocal flags ACLOCAL_FLAGS
configure should honor aclocal flags ACLOCAL_FLAGS
Status: RESOLVED OBSOLETE
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks: 641445
 
 
Reported: 2011-02-04 07:49 UTC by Craig Keogh
Modified: 2011-03-05 19:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Honor aclocal flags (631 bytes, patch)
2011-02-04 07:50 UTC, Craig Keogh
rejected Details | Review

Description Craig Keogh 2011-02-04 07:49:43 UTC
I'm building gdk-pixbuf via JHBuild. gdk-pixbuf builds
successfully. If upstream then updates configure.in, then I run 'make', which
attempts a reconfigure, but fails.

This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I
/opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require
every module to support ACLOCAL_FLAGS, but there isn't a way around it until
automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details
in the JHBuild bug 634617.

The build failure is:
make  V=1
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gdk-pixbuf/missing --run aclocal-1.11 -I m4
configure.ac:402: warning: macro `AM_PATH_GLIB_2_0' not found in library
configure.ac:31: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=gdk-pixbuf
 cd . && /bin/sh /home/Oxyde/gnome/gdk-pixbuf/missing --run automake-1.11 --foreign
configure.ac:31: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=gdk-pixbuf
gtk-doc.make:32: EXTRA_DIST multiply defined in condition TRUE ...
docs/reference/gdk-pixbuf/Makefile.am:73:   `gtk-doc.make' included from here
Makefile.decl:7: ... `EXTRA_DIST' previously defined here
docs/reference/gdk-pixbuf/Makefile.am:2:   `Makefile.decl' included from here
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/gdk-pixbuf/missing --run autoconf
configure.ac:31: warning: AC_INIT: not a literal: http://bugzilla.gnome.org/enter_bug.cgi?product=gdk-pixbuf
configure.ac:408: error: possibly undefined macro: AM_PATH_GLIB_2_0
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
make: *** [configure] Error 1
Comment 1 Craig Keogh 2011-02-04 07:50:26 UTC
Created attachment 180045 [details] [review]
Honor aclocal flags
Comment 2 David King 2011-03-05 08:27:37 UTC
Comment on attachment 180045 [details] [review]
Honor aclocal flags

Seems that this change was already committed together with some autoreconf cleanup work in commit 3feebdc857f73495f19316958b1ded3b4b12e7d9.