After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641280 - Multipart messages quoting
Multipart messages quoting
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.32.x
Other Linux
: Normal minor
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 645676 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-02 18:40 UTC by Daniel Fort
Modified: 2011-04-22 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use quoted values in Content-Disposition headers. (4.00 KB, patch)
2011-03-31 19:18 UTC, Eitan Isaacson 		none Details | Review

Description Daniel Fort 2011-02-02 18:40:52 UTC 
Some servers require parameter names to be always quoted.
It's not by RFC, but that happens.

To reproduce you can try posting to http://fastpic.ru/uploadmulti following fields:
submit => 1
check_thumb => size
thumb_size => 170
uploading => 1
file[] => some image file

server will respond 500 error.
Comment 1 Daniel Fort 2011-02-04 22:37:22 UTC 
I did additional research on this bug and found out that nginx server fails to recieve such requests.
Comment 2 Dan Winship 2011-03-25 21:48:27 UTC 
*** Bug 645676 has been marked as a duplicate of this bug. ***
Comment 3 Eitan Isaacson 2011-03-31 19:18:40 UTC 
Created attachment 184811 [details] [review]
Use quoted values in Content-Disposition headers.

This fixes a Vimeo bug where its upload endpoint only accepts
Content-Disposition values that are quoted. Even though RFC 2231 explicity
says that servers should accept mix of quoted and unquoted values.
http://vimeo.com/forums/topic:35969
Comment 4 Eitan Isaacson 2011-03-31 19:19:07 UTC 
Re-attached patch from bug 645676 here.
Comment 5 Dan Winship 2011-04-07 12:37:45 UTC 
That patch wasn't quite right; the rfc2231 format requires special encoding and no quotes. I wrote my own patch (along with a few other related updates), added some regression tests, and just pushed it to git. It will be in libsoup 2.34.1. Thanks for the bug report / debugging / patches.