GNOME Bugzilla – Bug 640883
configure should honor aclocal flags ACLOCAL_FLAGS
Last modified: 2011-02-04 07:39:15 UTC
I'm building totem-pl-parser via JHBuild. totem-pl-parser builds successfully. If upstream then updates configure.ac, the build fails: make V=1 CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /home/Oxyde/gnome/totem-pl-parser/missing --run aclocal-1.11 -I m4 cd . && /bin/sh /home/Oxyde/gnome/totem-pl-parser/missing --run automake-1.11 --gnu gtk-doc.make:7: GTK_DOC_USE_LIBTOOL does not appear in AM_CONDITIONAL docs/reference/Makefile.am:96: `gtk-doc.make' included from here gtk-doc.make:51: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL docs/reference/Makefile.am:96: `gtk-doc.make' included from here gtk-doc.make:52: GTK_DOC_BUILD_HTML does not appear in AM_CONDITIONAL docs/reference/Makefile.am:96: `gtk-doc.make' included from here gtk-doc.make:57: GTK_DOC_BUILD_PDF does not appear in AM_CONDITIONAL docs/reference/Makefile.am:96: `gtk-doc.make' included from here gtk-doc.make:226: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL docs/reference/Makefile.am:96: `gtk-doc.make' included from here docs/reference/Makefile.am:102: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL plparse/Makefile.am:183: HAVE_INTROSPECTION does not appear in AM_CONDITIONAL make: *** [Makefile.in] Error 1 This is because JHBuild sets ACLOCAL_FLAGS to include the sandbox (e.g. -I /opt/gnome/share/aclocal). One may argue it is silly for JHBuild to require every module to support ACLOCAL_FLAGS, but there isn't a way around it until automake-1.12 is out - which includes support for ACLOCAL_PATH. Further details in the JHBuild bug 634617.
Created attachment 179576 [details] [review] Honor aclocal flags
I thought gnome-autogen.sh did this for us? Where else is aclocal called from within the build system which would circumvent what gnome-autogen.sh does?
gnome-autogen.sh is not called in this circumstance. totem-pl-parser was 'configure'd successfully earlier. This circumstance only 'make' was called, which determined a reconfigure was necessary (due to changed configure.ac). It's this reconfigure that breaks.
This should NOT be added to configure; instead put ACLOCAL_AMFLAGS = ${ACLOCAL_FLAGS} into the toplevel Makefile.am.
Review of attachment 179576 [details] [review]: Could you change your patch as per Christian's comment #4, and add a comment in the makefile pointing to this bug report please? Thanks.
Created attachment 179866 [details] [review] Honor aclocal flags Sorry for my incorrect first patch, I don't know autotools very well, and I just copied what other modules did. Christian, What problems does configure.ac ACLOCAL="$ACLOCAL $ACLOCAL_FLAGS" cause? Should I look at fixing the 24 GNOME modules that do this?
Comment on attachment 179866 [details] [review] Honor aclocal flags Would be great if the patch actually applied in the future.
commit 6b3f4f5f88f850578065251762cd7258f837c2b1 Author: Craig Keogh <cskeogh@adam.com.au> Date: Wed Feb 2 21:38:42 2011 +1030 Honor aclocal flags https://bugzilla.gnome.org/show_bug.cgi?id=640883
> Would be great if the patch actually applied in the future. It does apply correctly. This bug is against totem-pl-parser, but you've applied it to totem: http://git.gnome.org/browse/totem/commit/?id=6b3f4f5f88f850578065251762cd7258f837c2b1
Comment on attachment 179866 [details] [review] Honor aclocal flags And applied to the correct module now... Attachment 179866 [details] pushed as e5efbb8 - Honor aclocal flags