GNOME Bugzilla – Bug 637667
Profiles are not always loaded correctly
Last modified: 2010-12-24 11:03:51 UTC
From Halim on the orca-list: ~~~~~~~ After loading a profile it would be nice if the settings could be applied automaticaly. EG.: prof1 has a diferent synth setting as prof2. Currently when I load prof2 I need to press apply after that to get the new settings applied to the synth. ~~~~~~~ I've not looked into it yet, but I suspect it's not that profiles are not applied automatically (as I believe they are in many cases, and that was the intent all along). Instead, I think it's related specifically to speech settings. Independent of this new feature, we've done some "special" things around speech and preferences and I suspect something in that code is interfering with the load.
Some I'm noticing several things and may split this bug apart, but for now.... 1. When I press load for a newly-created profile or for a profile already in existence and there are no speech settings involved, it takes effect immediately and without the need for pressing the apply button. 2. I have reproduced what Halim describes once (i.e. load followed by apply caused the profile to take). 3. I have seen successful instances where loading an speech-related profile (e.g. french and spanish) have taken effect as soon as I press the load button. 4. I have seen instances where no matter what I do, I cannot get my new speech settings to load (i.e. even after I press the Apply button). It's all rather odd. But it's all speech related as best as I can tell. And it doesn't happen all the time. So it's just a matter of figuring out the quirk. Still investigating.
Created attachment 176797 [details] [review] proposed fix It seems that the inconsistency I described earlier was in part mine. Sometimes I was pressing Apply first I suspect before saving the profile. With this patch, at least so far, languages are doing the right thing and doing so upon load. Ale, it's a one-liner. :-) Please review. Thanks!
Review of attachment 176797 [details] [review]: Ok.
Comment on attachment 176797 [details] [review] proposed fix http://git.gnome.org/browse/orca/commit/?id=94d88190c6e66ee78f76f401510f3c19166e1330
I can still reproduce the issue here that settings are correctly set in the preferences UI but not applied to synths/brailledevices. EG.: prof1 (nobraille, speech-dispatcher, german mbrola output) prof2: (Braille, speech-dispatcher espeak output module). When I switch from prof1 to prof2 braille gets enabled but when switching back to prof1 it gets not disabled. The used Synthesizer is always the same after loading the profile. It should change because mbrola != espeak :-).
Reopening. Halim, when I was debugging this, if I had a user-settings.conf that was pre-fix, I didn't see the fix. But when I deleted that file and started over with the fix having already been installed, things worked as expected. Can you confirm you removed your user-settings.conf, got the very latest Orca from master, and are *still* seeing the same issues? Thanks!
yes i can confirm this. I wrote more about the issues in orca list. It seems that orca loads the profile and changes only synth params like rate and pitch. However it doesn't change the selected synth (espeak, festival, ibmtts ...). Another problem is that It doesn't update braille settings. Braille stays activated if turned of in the currently loaded profile. When I press esc after loading a profile, orca stopps speaking and only braille is active. When this happens I can't quit orca with orca+q.
Created attachment 176936 [details] [review] restart speech to ensure it gets loaded Halim, does this solve your speech problem? (Regarding the braille issue you mentioned, I'll look into that next, but that is not the same as this bug, nor is it fixed by this patch.)
Created attachment 176963 [details] [review] hopefully THE fix for all the issues. Seriously. I think this fixes the speech loading, braille loading, and keybindings loading issues. I've tested. Please do the same. Thanks!
Comment on attachment 176963 [details] [review] hopefully THE fix for all the issues. Seriously. http://git.gnome.org/browse/orca/commit/?id=0dd2963cc590917775521deebd79675af270e0cd
So based on the recent list discussion, it appears we have (or rather had) two separate issues: 1. Profiles are not always getting fully loaded 2. Profiles are not always getting correctly saved The most recent patch for this bug addresses item 1 -- and I'm relatively certain, does so fully. We're now calling the same method that loads/reloads settings in orca.py. Therefore, *this* bug (aka issue #1) is fixed. Issue number 2 is resulting in duplicate settings being written out. So when we correctly load the new profile, some things (speech, keybindings) seem unchanged. Issue number 2 is filed as bug 637930.