After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637393 - additionnal frames of text objects
additionnal frames of text objects
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
unspecified
Other All
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-12-16 15:37 UTC by Frédéric Parrenin
Modified: 2010-12-17 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
.xls file to reproduce the problem (67.50 KB, application/vnd.ms-excel)
2010-12-16 15:38 UTC, Frédéric Parrenin
  Details
Proposed patch (1.69 KB, patch)
2010-12-16 21:05 UTC, Jean Bréfort
none Details | Review
fixed patch (removed some printf debug). (1.58 KB, patch)
2010-12-16 21:16 UTC, Jean Bréfort
none Details | Review

Description Frédéric Parrenin 2010-12-16 15:37:25 UTC
When opening the attached .xls file, text objects have visible frames while they do not in XL.
Comment 1 Frédéric Parrenin 2010-12-16 15:38:29 UTC
Created attachment 176536 [details]
.xls file to reproduce the problem
Comment 2 Andreas J. Guelzow 2010-12-16 17:52:28 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 563782 ***
Comment 3 Jean Bréfort 2010-12-16 19:20:30 UTC
Looks like it is a different issue. The style dialog box says no line while a line is actually displayed.
Comment 4 Jean Bréfort 2010-12-16 20:05:19 UTC
The issue comes from different auto line type definition. Excel defaut seems invisible line while gnumeric uses solid line.
Comment 5 Jean Bréfort 2010-12-16 21:05:34 UTC
Created attachment 176551 [details] [review]
Proposed patch

It was really part of the unfixed things in #563782. I know the Jody does not like setting auto things to not auto, but I don't see how we might do when the defaults are so different.
Comment 6 Jean Bréfort 2010-12-16 21:16:53 UTC
Created attachment 176556 [details] [review]
fixed patch (removed some printf debug).
Comment 7 Andreas J. Guelzow 2010-12-16 22:06:07 UTC
"auto" does not mean "default". 

If the frame is really set to "auto" then it means that the file creator wants the application to figure out what to do. I think under those circumstances it is correct that it may look different in one application than in another.

If the user would want to fix the style, they should have/would have specified a format.
Comment 8 Jean Bréfort 2010-12-17 07:29:45 UTC
In this specific case, excel has no "auto", just "default", and our code translates currently that to "auto".
Comment 9 Andreas J. Guelzow 2010-12-17 07:52:24 UTC
Okay, I see no problem with mapping Excel's "default" to an appropriate (non-auto, non-default) style in Gnumeric.
Comment 10 Jean Bréfort 2010-12-17 11:07:52 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.