After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636463 - Display delivery reports
Display delivery reports
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
: 640689 641052 (view as bug list)
Depends on: 627726
Blocks: 647530
 
 
Reported: 2010-12-04 16:54 UTC by Petr Tomasek
Modified: 2011-05-05 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Petr Tomasek 2010-12-04 16:54:12 UTC
An example of another XMPP client implementing XEP-0198/"Ack": http://www.kismith.co.uk/wordpress/index.php/2010/09/07/reliable-messaging-in-swift/

The SPEC: http://xmpp.org/extensions/xep-0198.html

It would be nice If Empathy had support at least for the "Ack" and "Resumption features".
Comment 1 Petr Tomasek 2010-12-04 17:11:02 UTC
Yet another possibility how to implement the GUI for the "ACK" feature: http://ayena.de/gsoc_mid_term_approaching
Comment 2 Guillaume Desmottes 2010-12-06 11:01:38 UTC
Ok, so we have different issues here:
A) telepathy-gabble should use XEP-0198 to generate delivery reports
B) telepathy-gabble should implement resumption
C) Empathy should display delivery report in some way

A) and B) and gabble specific, can you please open 2 bugs for those on bugs.freedesktop.org

C) is the only Empathy task, so I'd rename this bug. It is blocked by implementing Messages in Empathy (bug #627726).
Comment 3 Guillaume Desmottes 2011-01-21 08:51:12 UTC
I'm also not sure about how this should be displayed in the UI. A spinner next to the message spinning while waiting for the ack? A sending icon changing to a sent one?
Comment 4 Guillaume Desmottes 2011-01-27 09:44:11 UTC
*** Bug 640689 has been marked as a duplicate of this bug. ***
Comment 5 Severo Raz 2011-01-27 23:29:10 UTC
I think it is very unnecessary to display any kind of visual feedback unless the message sending fails.
If such is the case, then the user should be notified. Maybe a short notice below the message and a "Retry sending" button would be my suggestion.
Comment 6 Severo Raz 2011-01-27 23:41:06 UTC
I think it is very unnecessary to display any kind of visual feedback unless the message sending fails.
If such is the case, then the user should be notified. Maybe a short notice below the message and a "Retry sending" button would be my suggestion.
Comment 7 Guillaume Desmottes 2011-02-01 08:47:19 UTC
*** Bug 641052 has been marked as a duplicate of this bug. ***
Comment 8 Jonathon Jongsma 2011-03-10 15:13:20 UTC
Another situation to consider:
 It's my understanding that in some protocols, a message that you send from a different client can sometimes be echoed back to all other clients.  These echos can then be represented by the CM as delivery reports.  In the case that empathy receives a delivery report for a message that it didn't send, it could simply display that message in the chat window so that you have a full picture of the conversation from all clients.
Comment 9 Danielle Madeley 2011-04-12 06:32:58 UTC
Success delivery reports are important on channels where delivery takes some time, e.g. SMS.
Comment 10 Severo Raz 2011-04-12 06:53:30 UTC
Success delivery reports are important whenever delivery failures are possible, I'd say.
Comment 11 Guillaume Desmottes 2011-04-21 09:23:29 UTC
We are considering to drop old themes support (bug #645921) so having this feature implemented only in Adium themes is fine by me.

I see 3 cases here:

A) Should we display something when we are sending a message? If we do, we could use either a spinner as done in Swift (cf [1] hey they are using Adium themes as well!) or a "sending" image as on the N900.

B) If sending failed, we certainly should display it. Write the message in red and below in grey the reason of the failing and a "Retry" button maybe?

C) Echoed message. I think those should appear as backlog as we do with archived messages. I suspect this case is a bit different from A and B; maybe we could split it to another bug and focus on A) and B) first?

[1] http://www.kismith.co.uk/wordpress/index.php/2010/09/07/reliable-messaging-in-swift/
Comment 12 Danielle Madeley 2011-05-05 07:45:41 UTC
Branch to add a spinner to the tab. Also fixes #646682.

http://cgit.collabora.co.uk/git/user/danni/empathy.git/log/?h=delivery-reports-rebase
Comment 13 Guillaume Desmottes 2011-05-05 08:20:46 UTC
++
Comment 14 Danielle Madeley 2011-05-05 08:25:39 UTC
Merged.

Should we should keep this bug open to add per-message delivery spinners and other delivery-report features?
Comment 15 Guillaume Desmottes 2011-05-05 11:47:15 UTC
I'd rather use separated bugs. Closing this one as the main feature is now in master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.