GNOME Bugzilla – Bug 63459
New filters patch (against 1.2.1) see attachment
Last modified: 2009-08-15 18:40:50 UTC
This patch is almost only a GUI redesign of the filters dialog box. Consider it less tested than other patches, but I wanted to make it available now to let you tell me about the new GUI I thought about. I think it is simpler, but I want you to tell me if you agree ;-) Have fun.
Created attachment 5940 [details] patch bzipped
I have forgotten to mention that this patch is to be applied AFTER the filters-1.2.1-1.patch (bug 61072). Sorry
Created attachment 5974 [details] emmanuels patches merged against cvs
attach 5974 is emmanuel's 1.2.1 filter and new ui patches applied on 20011106 cvs with some slight corrections
Created attachment 5999 [details] filters pacth (I'll sync with Carlos modifs later)
I forgot to mention that patch is against 1.2.3 (id 5999).
Created attachment 6000 [details] Small doc (in english)
Created attachment 6001 [details] Petit manuel (en francais)
Created attachment 6017 [details] [review] diff for libbalsa/filter.c so it trashes messages correctly
Created attachment 6035 [details] New filters patch (small improvments, but more important this one will enable you to compile the "search" patch)
The old filters patch were not "compatible" with the search-1.2.3 patch (the latter won't compile). So I uploaded new ones (filters-1.2.3-2.patch, and search-1.2.3-2.patch). So to have filters just apply filters-1.2.3-2 against clean balsa-1.2.3, to alsa have search functions apply search-1.2.3-2 AFTER filters-1.2.3-2. Then the classic process : automake ./configure --enable-all make and "make uninstall" as root if you want ot install this one (don't forget that this stuff is experimental :)
Created attachment 6036 [details] search functions bzipped patch (see comments)
Attachment no 6035 commited to BALSA_FILTERS branch. Other parts will (most likely) follow shortly.
*** Bug 61072 has been marked as a duplicate of this bug. ***
Patch no 6036 (searching) is in. Actually, I am convinced entire model of message matching should be modified in order to enable server-side IMAP filtering (probably for balsa-1.5.x series). I think the filtering should be based on LibBalsaMailbox::libbalsa_mailbox_get_matching_messages(mailbox, condition/filter). This is quite crucial when searching message body but an improvement is possible even when searching headers: currently, strings are allocated/deallocated on searching and this can be optimized out.
Created attachment 6064 [details] New bzipped patches, correct 2 old bugs, and polish GUI a bit
Created attachment 6079 [details] new patch (replaces the previous one that was broken :( )
The previous patch (filters-1.2.3-3) has escaped my wild patches prison :) It was totally broken : the filters won't get saved on-disk with this patch. Sorry for that, please replace with filters-1.2.3-4.patch.
Patch (id=6079) does not apply to CVS.
Created attachment 6097 [details] new filters patch (correct weird bugs in save/load mechanism)
here are (I hope) the last patch that deals with filters save/load problems. The last patches had different problems leading to incoherent filters config sections. So if you encounter problems with preceding patches, try this one, it should be a lot better, and tell me if it's not as better as I think ;) Sorry if one of the bugs hit you.
Created attachment 6228 [details] New filters patch : bugfixes and UI polishing
Has all this been commited? Can this report be closed?
OK I'll maintain the filter patches against 1.2.x for a while I think (until next debian release because of dependancies mess). So if you want me to publicly release the updated patches against 1.2.x e-mail me (shortly). If I have enough request I'll keep on releasing these patches on bugzilla, else we'll close that report. Thanks
Filters considered implemented. I am closing the report.
balsa-1.3.5 and 2.0.0 released, closing this report for good.