After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630644 - Incorrect rectangle structure when calling gs-mag via DBus.
Incorrect rectangle structure when calling gs-mag via DBus.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: magnification
unspecified
Other Linux
: Normal normal
: 2.91.0
Assigned To: Joseph Scheuhammer
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-26 17:56 UTC by Joseph Scheuhammer
Modified: 2010-10-03 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for bug #630644 - Modified gsmag.py to pass RectBounds arrays as [left, top, right, bottom] (instead of [left, top, width, height]) when invoking GNOME Shell magnifier via DBus. (2.67 KB, patch)
2010-09-26 18:03 UTC, Joseph Scheuhammer 		committed Details | Review

Description Joseph Scheuhammer 2010-09-26 17:56:12 UTC 
In gsmag.py, when calling gnomeshell-mag via dbus, the arrays representing RectBounds are passed as [left, top, width, height].  But,they should be
[left, top, right, bottom].  Compare with gnome-shell bug 626123.

Functions to fix in gsmag.py are:

__setupZoomer():
    - Magnifier.createZoomRegion()
    - ZoomRegion.moveResize()

_setROICursorPush():
    - ZoomRegion.getRoi()

magnifyAccessible():
    - ZoomRegion.getRoi()

updateROIDimensions():
    - ZoomRegion.getRoi()
Comment 1 Joseph Scheuhammer 2010-09-26 18:03:57 UTC 
Created attachment 171136 [details] [review]
Fix for bug #630644 - Modified gsmag.py to pass RectBounds arrays as [left, top, right, bottom] (instead of [left, top, width, height]) when invoking GNOME Shell magnifier via DBus.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-10-03 12:09:15 UTC 
Comment on attachment 171136 [details] [review]
Fix for bug #630644 - Modified gsmag.py to pass RectBounds arrays as [left, top, right, bottom] (instead of [left, top, width, height]) when invoking GNOME Shell magnifier via DBus.

Thanks Joseph!

Committed to master:
http://git.gnome.org/browse/orca/commit/?id=086806127228565f7cbe0811059e70ae5e0024d3