After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628518 - build: webkit dependency should be optional
build: webkit dependency should be optional
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-01 14:54 UTC by Arun Raghavan
Modified: 2012-03-18 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
git-formatted version of Gentoo's make-webkit-optional patch (2.37 KB, patch)
2011-05-24 01:38 UTC, Dustin C. Hatch 		none Details | Review

Description Arun Raghavan 2010-09-01 14:54:09 UTC 
The webkit dependency should be made optional. Patch against 1.7.4 can be found at:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-sound/banshee/files/banshee-1.7.4-make-webkit-optional.patch?revision=1.1
Comment 1 Arun Raghavan 2010-09-01 14:55:09 UTC 
Apologies to those who got CC'ed. I misunderstood the clone feature on Bugzilla.
Comment 2 Pacho Ramos 2011-04-07 08:23:27 UTC 
Any news here?
Comment 3 Dustin C. Hatch 2011-05-24 01:38:09 UTC 
Created attachment 188426 [details] [review]
git-formatted version of Gentoo's make-webkit-optional patch

In the hopes that it might speed this along, I've attached Arun's patch with git formatting, ready to `git am` onto master :)

In case anyone is curious as to the utility of this patch, it helps keep the dependency tree down when some features won't be needed. No since in building webkit-gtk, etc. if the Amazon MP3 store won't be used or Wikipedia articles are irrelevant.
Comment 4 Pacho Ramos 2011-11-01 11:45:56 UTC 
Could this be committed for the next major version please? Thanks
Comment 5 Bertrand Lorentz 2012-03-18 14:41:16 UTC 
I've just committed the patch, thanks for it !

Sorry it took so long, I missed this bug report, and I thought we already had a --disable-webkit option, because it was mentioned in our README...