After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627835 - Base Rating Widget on Hyena
Base Rating Widget on Hyena
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other All
: Normal normal
: 0.7.3
Assigned To: F-spot maintainers
F-spot maintainers
Depends on: 627833
Blocks:
 
 
Reported: 2010-08-24 11:55 UTC by Mike Gemünde
Modified: 2010-09-08 16:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use ComplexMenuItem from Hyena (5.98 KB, patch)
2010-08-24 11:55 UTC, Mike Gemünde
committed Details | Review
Base rating widget on Hyena RatingEntry (21.89 KB, patch)
2010-08-24 11:55 UTC, Mike Gemünde
none Details | Review
Base rating widget on Hyena RatingEntry (30.65 KB, patch)
2010-08-24 12:05 UTC, Mike Gemünde
reviewed Details | Review
Base rating widget on Hyena RatingEntry (30.60 KB, patch)
2010-08-25 06:28 UTC, Mike Gemünde
none Details | Review
Base rating widget on Hyena RatingEntry (30.64 KB, patch)
2010-08-25 06:48 UTC, Mike Gemünde
committed Details | Review

Description Mike Gemünde 2010-08-24 11:55:29 UTC
This commits base the F-Spot rating widget on Hyena's one.
Comment 1 Mike Gemünde 2010-08-24 11:55:31 UTC
Created attachment 168633 [details] [review]
Use ComplexMenuItem from Hyena
Comment 2 Mike Gemünde 2010-08-24 11:55:35 UTC
Created attachment 168634 [details] [review]
Base rating widget on Hyena RatingEntry
Comment 3 Mike Gemünde 2010-08-24 11:57:14 UTC
The dependent bug must be commited to Hyena first and the Hyena submodule in F-Spot must include those patches.
Comment 4 Mike Gemünde 2010-08-24 12:05:12 UTC
Created attachment 168638 [details] [review]
Base rating widget on Hyena RatingEntry

(This commit also adds the new files to Monodevelop)
Comment 5 Ruben Vermeersch 2010-08-24 14:54:28 UTC
Review of attachment 168633 [details] [review]:

Looks good.
Comment 6 Ruben Vermeersch 2010-08-24 14:58:37 UTC
Review of attachment 168638 [details] [review]:

Lovely refactoring. Like the reduction in code. Can we split this out of MainApp (see below). I gradually want that module to become tiny, and the other assemblies to be the base of more awesome.

::: src/Clients/MainApp/FSpot.Widgets/FSpotRatingRenderer.cs
@@ +20,3 @@
+namespace FSpot.Widgets
+{
+    public class FSpotRatingRenderer : RatingRenderer

Can this be moved from MainApp to FSpot.Gui?

::: src/Clients/MainApp/FSpot.Widgets/IconView.cs
@@ +970,3 @@
 			if (DisplayRatings && photo.Rating > 0 && region.X == draw.X && region.X != 0) {
+                var rating = new FSpotRatingRenderer () {
+                    Size = 16, Value = (int) photo.Rating

Isn't 16 the default value? No need to set it then, right?
Comment 7 Mike Gemünde 2010-08-25 06:28:14 UTC
Created attachment 168706 [details] [review]
Base rating widget on Hyena RatingEntry

... and also move some of the files to FSpot.Core
Comment 8 Mike Gemünde 2010-08-25 06:48:28 UTC
Created attachment 168707 [details] [review]
Base rating widget on Hyena RatingEntry

next try....

I saw you comment regarding to the size of the stars. default of Hyena
is 14. But I think 14 is also ok, it looks better (imho).
Comment 9 Ruben Vermeersch 2010-08-25 14:12:34 UTC
Review of attachment 168707 [details] [review]:

Needs work on making it more discoverable, as discussed on XMPP.
Comment 10 Mike Gemünde 2010-08-26 05:50:57 UTC
committed

Attachment 168707 [details] pushed as b0824dd - Base rating widget on Hyena RatingEntry