GNOME Bugzilla – Bug 625904
Port to GSettings
Last modified: 2012-01-11 14:44:15 UTC
http://live.gnome.org/GnomeGoals/GSettingsMigration
gnotravex is done: http://git.gnome.org/browse/gnome-games/commit/?id=506933366ffe2448a557f571bffc7f4ee14e1f10
iagno and gnomine are done
mahjongg is done: http://git.gnome.org/browse/gnome-games/commit/?id=b5dfe0c5cb36a2ded1f7ba73a3f46d85234a5f11
Created attachment 194864 [details] [review] Gnobots2 migration Is my first patch ever, so im not sure if all will be ok :)
Created attachment 194865 [details] [review] Gnobots2 Gsettings migration schema file Last patch was missing the new schema xml file. Here is. Sorry :(
Hi Marc, Thanks for the patch :) I think that there is a small oversight in the properties file. There is still a call to games_conf_get_keyval_with_default in the load_keys function there. Also the settings variable is newer set in that file. The schema file seems to have few places with < _summary> instead of <_summary>. Otherwise it looks good. I'll commit the patch with the fixes before the 3.1.90 release on monday.
Created attachment 194968 [details] [review] GConf to GSettings migration I hope all be ok now
Created attachment 194974 [details] [review] glines GConf to GSettings migration glines migration
Created attachment 195130 [details] [review] gnobots: updated patch I updated your patch Marc with a few fixes (use extern GSettings variable, change '_' to '-' in a settings name, removed reference to non-existing g_settings_get_keyval, indentation in xml file) It builds now but unfortunately it turns out that libgames-support/games-controls.[ch] needs to be ported as well. Gnect and gnibbles both depend on that code so we need to port all three games at the same time. I won't be able to do that before the 3.1.90 release tonight.
Review of attachment 194974 [details] [review]: the patch only contains a new schema file for gsettings
Created attachment 195342 [details] [review] glines GConf to GSettings migration It builds :=)
Created attachment 195348 [details] [review] glines GConf to GSettings migration Last had some gnobots changes, this is only the glines changes on current master.
Created attachment 195349 [details] [review] glines delete old schema file
I have done game-controls migration. also did gnect, ill start gnibbles but quadrapassel is complaining too due to game-controls changes, so ill have to modify it too.
Created attachment 195729 [details] [review] glines GConf to GSettings migration Latest glines migration. Indentation fixed.
Comment on attachment 195729 [details] [review] glines GConf to GSettings migration Committed to master: http://git.gnome.org/browse/gnome-games/commit/?id=96a72639ba3c90130997704e0f62dd6b00cffb4d Thanks Marc!
Hey, im again with this migration. Which games are still needing the change to gsettings?
The remaining tasks are swell-foop (bug 664944) gnect (bug 666040) gnibbles (bug 666041) gnobots2 (bug 666042) gnoski (bug 666043) gtali (bug 666044) lightsoff (bug 666045) quadrapassel (bug 666046)
Also gnome-sudoku (bug 667321)