GNOME Bugzilla – Bug 622482
photography iface review
Last modified: 2012-07-10 23:18:40 UTC
This bug is for reviewing GstPhotography completeness. The interface show cover usual settings for photography and the still image capture process. Things missing: 1.) A way to turn off Auto-Whitebalance. Could be done by adding GST_PHOTOGRAPHY_WB_MODE_OFF 2.) A way to turn off Auto-Exposure.
All public symbols should have GstPhotography prefix, thus we need to rename the enum types e.g. GstWhiteBalanceMode -> GstPhotographyWhiteBalanceMode The GStreamer API uses US American English spelling, not British English spelling: Thus we should change "COLOUR" => "COLOR".
Created attachment 172349 [details] [review] 0001-photography-Add-GstPhotography-prefix-and-fix-spelli.patch Add GstPhotography prefix to public symbols and fix spelling colour->color
Created attachment 172352 [details] [review] 0002-photography-Add-manual-control-of-exposure-focus-and.patch Add new interface properties and mode for better manual control of exposure, focus and white balance, proposed updates are summarized below. Also, how about deprecating gst_photography_get/set_* functions and having only respective interface properties? White-balance: new wb mode option GST_PHOTOGRAPHY_WB_MODE_MANUAL new interface proprety "white-balance", integer type for manual setting/getting of white balance as color temperature in Kelvin units(?) FIXME: to be checked if the unit is valid/sufficient So if GST_PHOTOGRAPHY_WB_MODE_MANUAL is set then automatic white balance is disabled and current value should remain. Application can query current or set new value. Exposure: new mode "exposure-mode": GST_PHOTOGRAPHY_EXPOSURE_MODE_AUTO = 0, GST_PHOTOGRAPHY_EXPOSURE_MODE_MANUAL change property name: "exposure" -> "exposure-time" new interface properties: "analog-gain", analog gain applied to the sensor "min-exposure-time", for setting exposure time limit to autoexposure "max-exposure-time", for setting exposure time limit to autoexposure Again, setting GST_PHOTOGRAPHY_EXPOSURE_MODE_MANUAL will turn autoexposure off, current exposure remains and exposure settings can be controlled using interface properties. Focusing: new focus mode option GST_PHOTOGRAPHY_FOCUS_MODE_MANUAL new interface property for setting/getting current focus value: "lens-focus" float type, lens distance from image plane in millimeter units
Review of attachment 172352 [details] [review]: ::: gst-libs/gst/interfaces/photography.h @@ +212,1 @@ } GstPhotographyFocusMode; These still miss API docs. Could be done as a followup patch. @@ +215,3 @@ + GST_PHOTOGRAPHY_EXPOSURE_MODE_AUTO = 0, + GST_PHOTOGRAPHY_EXPOSURE_MODE_MANUAL +} GstPhotographyExposureMode; Please add docs.
Created attachment 172917 [details] [review] Add GstPhotography prefix and fix spelling colour->color Rebase to HEAD and update -sections.txt for docs.
Created attachment 172918 [details] [review] Add manual control of exposure, focus and white balance Rebase to HEAD. New interface properties for manual white balance: white-point, color-temperature. White point should describe the color "white" as raw values. FIXME: check correct representation for white point. Change lens-focus property unit to diopter.
Created attachment 172920 [details] [review] Update documentation Update documentation
Created attachment 172921 [details] [review] use GstPhotographyNoiseReduction enumeration instead of guint Minor fix related to GstPhotographyNoiseReduction
Comment on attachment 172921 [details] [review] use GstPhotographyNoiseReduction enumeration instead of guint This change is already in git head
I'd like to get at least the spelling fixes and the doc fixes in. I'll push these after vacations if there are no more comments.
Hi! Any news on this? It would be nice to have this extra properties in GstPhotography.
> I'll push these after vacations if there are no more comments. Long vacation that ;) commit eabb238b2445084abe8aafdbb884368179b512fe Author: Lasse Laukkanen <ext-lasse.2.laukkanen@nokia.com> Date: Wed Oct 13 10:55:17 2010 +0300 photography: update documentation https://bugzilla.gnome.org/show_bug.cgi?id=622482 commit 3d94d8dc39c4e13069714c80a3584dd561a1e41b Author: Lasse Laukkanen <ext-lasse.2.laukkanen@nokia.com> Date: Thu Oct 14 10:49:55 2010 +0300 photography: Add manual control of exposure, focus and white balance Add new interface properties and mode for better manual control of exposure, focus and white balance. https://bugzilla.gnome.org/show_bug.cgi?id=622482 commit 8fd2fc662a7c36a2df4c2621dd88a0951395a820 Author: Lasse Laukkanen <ext-lasse.2.laukkanen@nokia.com> Date: Fri Oct 8 11:33:31 2010 +0300 photography: Add GstPhotography prefix and fix spelling colour->color https://bugzilla.gnome.org/show_bug.cgi?id=622482