GNOME Bugzilla – Bug 621508
TagLib support for CR2 files
Last modified: 2010-06-24 18:30:34 UTC
These commits implement support for CR2 files. For now, there are no test included because of the huge data of CR2 files.
Created attachment 163553 [details] [review] Introduce the class BaseTiffFile as base for all Tiff-based file formats The class BaseTiffFile is introduced to factor out some behavior which is common for all Tiff-based file formats.
Created attachment 163554 [details] [review] Add Property Writeable to Image.File Since we start supporting some file formats just for reading (at least for now) the property Writeable is added to Image.File to indicate if a file can be written back or not.
Created attachment 163555 [details] [review] Add support for Canon CR2 raw files This commits adds support to parse Canon CR2 RAW files. Since this format is based on the TIFF structure, reading is mostly based on this code.
Created attachment 163556 [details] [review] Extend the ParsePhoto example to also show the image size
Review of attachment 163553 [details] [review]: Looks clean.
Review of attachment 163554 [details] [review]: Cool, be sure to add a check to the unit tests that *demands* that a file is writable. Also, like you said: the readonly test should only work for files that are !Writable. That way we ensure that writing is always tested.
Review of attachment 163555 [details] [review]: Love how clean it is to add a RAW type that derives from Tiff. ::: src/TagLib/Cr2/Codec.cs @@ +41,3 @@ + /// of the media represented by the current instance. + /// </value> + public override string Description { get { return "CR2 File"; } } Probably better to call this "Canon RAW File".
Review of attachment 163556 [details] [review]: Shocked that we didn't have this yet.
Attachment 163556 [details] pushed as e51a0cc - Extend the ParsePhoto example to also show the image size Merged, great stuff! One step closer to world domination :-)