After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 619606 - only force to implement virtual methods that are tagged as GI_VFUNC_MUST_OVERRIDE
only force to implement virtual methods that are tagged as GI_VFUNC_MUST_OVER...
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-05-25 12:34 UTC by Tomeu Vizoso
Modified: 2010-12-08 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implement VFuncInfo.must_override to determine if a vfunc needs to be overridden (3.29 KB, patch)
2010-10-28 21:42 UTC, johnp 		none Details | Review

Description Tomeu Vizoso 2010-05-25 12:34:25 UTC 
As returned by g_vfunc_info_get_flags
Comment 1 johnp 2010-10-28 21:42:46 UTC 
Created attachment 173439 [details] [review]
implement VFuncInfo.must_override to determine if a vfunc needs to be overridden
Comment 2 johnp 2010-11-10 01:09:33 UTC 
In reality this isn't supported by gi and they debated changing it in gi.  Better fix is to not complain when overrides do not error out.
Comment 3 Tomeu Vizoso 2010-12-01 15:21:15 UTC 
(In reply to comment #2)
> In reality this isn't supported by gi and they debated changing it in gi. 
> Better fix is to not complain when overrides do not error out.

Do we have a ticket about removing that check?
Comment 4 johnp 2010-12-01 18:15:08 UTC 
I just checked in a better fix which came with the recursive vfunc patch.  We now do not error out in overrides since you might want to override a class but not implement all of its vfuncs.  It only errors out when subclassing if the vfunc pointer is NULL.  This still may break if there are vfuncs you are allowed to keep unset but I'm not aware if that is the case for any classes.