GNOME Bugzilla – Bug 612741
Include AAC profile in Banshee
Last modified: 2013-06-27 07:41:28 UTC
Currently Banshee is able to play AAC file, but even though media players can play them, Banshee won't propose converting FLACs into AAC, but only MP3. It's not good.
https://bugzilla.novell.com/show_bug.cgi?id=588048
We have an aac profile, but it was removed from the build on purpose: commit 5794cb70bdaa09fbe6aa55cec2973aba89475c34 Author: Aaron Bockover <abock@gnome.org> Date: Sat Aug 4 15:38:23 2007 * data/audio-profiles/Makefile.am: Do not install the aac/faac profile as the plugins it requires are very broken in GStreamer; this profile only confuses users We'd want to make sure those issues have been resolved before re-enabling.
Thank you for letting me know. I'd be thankful for leaving this bug open until it's (whatever it is) resolved and AAC profile comes back as eg. Sound Converter creates good AAC(+) files.
What is Sound Convertor? Feel free to do research on this, see if RB / Sound Juicer etc have added/changed/commented on an AAC profile (I think they might use the gnome-media one?), or figure out what Aaron meant by "the plugins it requires [that] are very broken" and see if they've been improved.
http://soundconverter.berlios.de/ Open source app which's the best at converting any input format into any I tried. And I tried a lot of them. RPM, I installed from, doesn't contain any profiles, so probably gnome-media profiles are utilised... But let me show you something. > $ rpm -qa|grep -i gnome|sort > gnome-icon-theme-2.28.0-2.2.noarch > gnome-keyring-2.28.0-3.5.i586 > gnome-vfs2-2.24.1-3.4.i586 > libgnome-2.28.0-2.4.i586 > libgnomecanvas-2.26.0-2.4.i586 > libgnomecanvas-lang-2.26.0-2.4.noarch > libgnomeui-2.24.2-2.3.i586 > libgnomeui-lang-2.24.2-2.3.noarch > python-gnome-2.28.0-2.3.i586 No gnome-media package and sondconverter still works. > the plugins it requires [that] are very broken Maybe he meant gstreamer-plugins-bad (or ugly) are somehow broken, buggy, or sth? Or there's something wrong with faac/faad? I don't know.
That profile deactivation appears to have been made in 2007, and it doesn't mention any upstream bugs to track. Does anyone know if the situation has improved sufficiently upstream in gstreamer?
As I told you comment before: AAC support in GStreamer seems fine.
Created attachment 169110 [details] [review] renable aac profile I think this is sufficient to reenable the aac profile, I sadly have no test content. Jakub can you try this?
Created attachment 169113 [details] [review] the shame That was shameful, now let's spell xml correctly.
I'd have to compile Banshee on my own. I'll mark it as my task for tomorrow.
Created attachment 169118 [details] Taglib Exception Okay, my N900 supports AAC so I tested this. It works and the files transcode to a playable state. We do get the attached TagLib exception every time. I will file this separately. Consider this a request to merge the patch attached above.
Can you give us a sample AAC? I'd try it out too.
The gnome-media AAC profile doesn't use the outputformat property (it leaves it set to the default of 0). I wonder if we should follow suit with ours? Can somebody test the profile with and without the outputformat property, and see if it makes a difference with GST, VLC, and iPod playback? I don't think we can re-enable this until after 1.8.0 due to the string freeze.
I'm guessing Aaron disabled it due to bug #490060 and bug #498667, for the record.
*** Bug 633552 has been marked as a duplicate of this bug. ***
Just to clarify on my bug report (633552) that was marked as duplicate for this bug: Banshee will also transcode AACs to other formats even when the iPod is capable of playing the AACs as is. Obviously that's no good, and I'd say that it is worse than just not being able to encode AACs..
Ryan, it is the same problem. Right now, as is noted above the AAC profile is disabled meaning you cannot encode nor transcode into AAC presently. I'll look at it when I return from vacation unless someone beats me to it.
Let me try again. I am not talking about encoding or transcoding TO AAC. I am talking about Banshee not understanding that existing AAC files are compatible with the iPod. Thus it transcodes AAC files into MP3s when it does not need to. Hopefully that's clear, I don't want to clutter up the bug discussion.
Ryan, I re-opened your bug, thanks for being patient.
Review of attachment 169113 [details] [review]: Hey David, Can you do the testing I mentioned in comment #13? Also, did you file that taglib# bug? I'd like to have it fixed before committing this.
I forgot about that but this gave me a change to try the very latest AAC profile in Banshee git. The report is here https://bugzilla.gnome.org/show_bug.cgi?id=634015
Committed, thanks David! To test, please use taglib-sharp from git master, or wait a few days for a new release.