After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611935 - Needs to explicitly link against X11 when needed
Needs to explicitly link against X11 when needed
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks: 611934
 
 
Reported: 2010-03-05 19:15 UTC by Guido Günther
Modified: 2010-03-20 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Explicitly link against X11 when needed (1.38 KB, patch)
2010-03-05 19:15 UTC, Guido Günther 		none Details | Review

Description Guido Günther 2010-03-05 19:15:58 UTC 
Created attachment 155351 [details] [review]
Explicitly link against X11 when needed

when using --no-undefined we need to explicitly link against X11 for
XkbGetKeyboard and friends. Attached patch does this if the X11
development files are available. This should be o.k. since platforms
using X11 for GDK have it installed since it's listed as a pkg-config
dependency.
It should also fix building with binutils-gold.
Comment 1 Daniel P. Berrange 2010-03-20 18:10:01 UTC 
Thanks, applied in this commit

commit f18f59cf0e1e162f2e7d6011396b0e875e144365
Author: Guido Günther <agx@sigxcpu.org>
Date:   Sat Mar 20 18:04:29 2010 +0000

    Explicitly link against X11 libs for XkbGetKeyboard
    
    When building with --no-undefined and modern linkers, X11 won't
    be found implicitly. Therefore it is neccessary to link directly
    to X11
    
    * configure.ac: Use pkgconfig to check for X11 libs
    * src/Makefile.am: Link against X11