After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 609763 - [fileformatchooser] Use accessor functions instead of direct access
[fileformatchooser] Use accessor functions instead of direct access
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Libegg maintenance
Libegg maintenance
Depends on:
Blocks: 585391 594053 615348
 
 
Reported: 2010-02-12 17:26 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-10 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use accessor funcions intead direct access (1.53 KB, patch)
2010-02-12 17:27 UTC, Javier Jardón (IRC: jjardon) 		accepted-commit_now Details | Review
Use accessor funcions intead direct access.v2 (2.82 KB, patch)
2010-02-12 19:16 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use GTK_CHECK_VERSION (2.30 KB, patch)
2010-02-12 19:34 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-02-12 17:26:11 UTC 
See http://live.gnome.org/GnomeGoals/UseGseal
Comment 1 Javier Jardón (IRC: jjardon) 2010-02-12 17:27:06 UTC 
Created attachment 153640 [details] [review]
 Use accessor funcions intead direct access
Comment 2 Bastien Nocera 2010-02-12 18:52:04 UTC 
Comment on attachment 153640 [details] [review]
 Use accessor funcions intead direct access

Does this require any deps upping in configure as well?
Comment 3 Christian Persch 2010-02-12 19:16:00 UTC 
Since this is code that's copypasted into other modules, I think using #if GTK_CHECK_VERSION(...) ... #else  ... #endif would be better here, so that one can use the latest version from libegg, but still not have to update the gtk req on the module.
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-12 19:16:04 UTC 
Created attachment 153655 [details] [review]
Use accessor funcions intead direct access.v2

Yeah, added autoools checking stuff
Comment 5 Javier Jardón (IRC: jjardon) 2010-02-12 19:34:31 UTC 
Created attachment 153658 [details] [review]
Use GTK_CHECK_VERSION

Sorry Christian, I didn't see your comment
Comment 6 Bastien Nocera 2010-02-15 12:26:42 UTC 
Looks fine to me
Comment 7 Javier Jardón (IRC: jjardon) 2010-02-16 02:53:55 UTC 
Comment on attachment 153658 [details] [review]
Use GTK_CHECK_VERSION

commit 8f7956634f4d1892b03eae49fd3fe77f1ed24d66