Created attachment 148842 [details] [review]
Use new_with_mnemonic, not new_with_label

Downstream bug #1 (https://bugzilla.redhat.com/show_bug.cgi?id=533019)

Description of problem:
Accelerator (underlined letter) for the "Delete Transaction" button in the
"Delete transaction" dialog is wrong.

Version-Release number of selected component (if applicable):
gnucash-2.2.9-1.fc11.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Delete a transaction
2. Look at confirmation dialog
3. Try pressing Alt-D

Actual results:
Shows as "_Delete transaction"; Alt-D does not work

Expected results:
"D" is underlined; Alt-D will activate button.

Additional info:
Other accelerators (e.g. Alt-C for Cancel) work correctly.  

Downstream bug #2 (https://bugzilla.redhat.com/show_bug.cgi?id=541915)

Description of problem:
When opening GnuCash for a file that is in use by another user, the dialog does
not use underline for the non-stock buttons.

Version-Release number of selected component (if applicable):
gnucash-2.2.9-2.fc12

How reproducible:
100%

Steps to Reproduce:
1.Make sure file has group read/write access and resides in a directory with
group read/write access for a group both users are in
2.As user1, start gnucash and open the file
3.Do the same as user2

Actual results:
GnuCash could not obtain the lock for ....

That database may be in use by another user, in which case you should not open
it. What would you like to do?

[_Open Anyway] [_Create New File] [Quit]

(the Q of Quit is underlined; nothing else is)

Expected results:
The O and C should be underlined, with no leading underscore character.  

...

Basically, gnc_gtk_dialog_add_button is using the wrong gtk function. Patch is against 2.3.7, but should apply to 2.2.x, I imagine.