After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600705 - accounts created in the assistant don't get a nice display name
accounts created in the assistant don't get a nice display name
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.27.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-04 16:56 UTC by Guillaume Desmottes
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/display-name-assistant-600705 (4.91 KB, patch)
2009-11-12 17:54 UTC, Guillaume Desmottes
accepted-commit_now Details | Review

Description Guillaume Desmottes 2009-11-04 16:56:38 UTC
They stay New <protocol> account.
Comment 1 Guillaume Desmottes 2009-11-12 17:54:40 UTC
Created attachment 147595 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/display-name-assistant-600705

 libempathy-gtk/empathy-account-widget.c |   53 +++++++++++++++++++++++++++++++
 libempathy-gtk/empathy-account-widget.h |    3 ++
 src/empathy-accounts-dialog.c           |   53 +-----------------------------
 3 files changed, 58 insertions(+), 51 deletions(-)
Comment 2 Cosimo Cecchi 2009-11-12 18:50:18 UTC
Review of attachment 147595 [details] [review]:

Looks good to me.
Comment 3 Guillaume Desmottes 2009-11-13 10:22:30 UTC
Thanks; merged to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

commit eac0b572a73559e88be8da3d62f15cf26d3bb1e1
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Nov 12 17:19:51 2009 +0000

    account-assistant: set default display name to newly created accounts (#600705)

commit 2969485fc42fed028d1e8506534469b97cd5a283
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Nov 12 17:15:51 2009 +0000

    empathy_account_widget_get_default_display_name: special case should be done in specialized widgets
    
    This requiers to refactor widget to actually inherit from
    EmpathyAccountWidget.

commit 07cb259462d9958e65d2f94aef6e5728e83ccf29
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Nov 12 17:13:21 2009 +0000

    move code generating the default display name of new account to account-widget
    
    This will allow us to:
    - Use this function from other places, like in the assistant.
    - Delegate special cases to the specialized versions of the widget.