After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600475 - Usage of (newly) deprecated GTK+ functions
Usage of (newly) deprecated GTK+ functions
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Builds
2.30.x
Other Linux
: Normal normal
: 3.0
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on: 610515
Blocks: 585692
 
 
Reported: 2009-11-02 21:28 UTC by Frederic Peters
Modified: 2011-02-23 19:22 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Replace deprecated gtk_button_pressed and gtk_button_released functions (1.71 KB, patch)
2009-11-02 21:35 UTC, Frederic Peters 		none Details | Review
Use 'button-press-event' and 'button-release-event' (1.93 KB, patch)
2009-11-25 19:21 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review

Description Frederic Peters 2009-11-02 21:28:06 UTC 
commit da8dde446d8316bbc4e64498ac18bef8985a0ce0
Author: Christian Dywan <christian@twotoasts.de>
Date:   Tue Oct 27 22:39:30 2009 +0100

    Deprecate functions according to deprecated GtkButton signals
    
    https://bugzilla.gnome.org/show_bug.cgi?id=599218

Has been commited to GTK+, and Nautilus is now failing with:

nautilus-navigation-action.c: In function ‘proxy_button_press_event_cb’:
nautilus-navigation-action.c:202: error: implicit declaration of function ‘gtk_button_pressed’
nautilus-navigation-action.c:202: error: nested extern declaration of ‘gtk_button_pressed’
nautilus-navigation-action.c: In function ‘proxy_button_release_event_cb’:
nautilus-navigation-action.c:214: error: implicit declaration of function ‘gtk_button_released’
nautilus-navigation-action.c:214: error: nested extern declaration of ‘gtk_button_released’
Comment 1 Frederic Peters 2009-11-02 21:35:02 UTC 
Created attachment 146779 [details] [review]
Replace deprecated gtk_button_pressed and gtk_button_released functions
Comment 2 Cosimo Cecchi 2009-11-03 00:50:55 UTC 
Hmm, it seems to me that the signals are deprecated as well?
Comment 3 Frederic Peters 2009-11-25 11:30:16 UTC 
commit 6ff1e3881e070a0a235208cc10dfdc53e8faa0aa
Author: Alexander Larsson <alexl@redhat.com>
Date:   Wed Nov 25 08:59:02 2009 +0100

    Avoid deprecated gtk_button_pressed/released

    We replace these with direct use of deprecated signals,
    which is not ideal either. However, it makes us not reference
    depcrecated symbols and makes it works. I don't know how else
    to solve this.
Comment 4 Javier Jardón (IRC: jjardon) 2009-11-25 19:21:09 UTC 
I've reopened this bug to use non-deprecated signals
Comment 5 Javier Jardón (IRC: jjardon) 2009-11-25 19:21:59 UTC 
Created attachment 148472 [details] [review]
Use 'button-press-event' and 'button-release-event'
Comment 6 Javier Jardón (IRC: jjardon) 2010-02-06 03:41:45 UTC 
Could some nautilus developer review this?
Comment 7 Cosimo Cecchi 2010-02-22 00:55:42 UTC 
Review of attachment 148472 [details] [review]:

Isn't it better to pass also the GdkEventButton to the signal?
Comment 8 Cosimo Cecchi 2010-04-09 11:28:33 UTC 
Javier, any update on this?
Comment 9 Javier Jardón (IRC: jjardon) 2010-04-09 13:12:16 UTC 
@Cosimo:

Seems that there is not a proper solution with current non-deprecate api.

Take a look to the bug #610515 to track the progress on possible solutions/patches.
Comment 10 Cosimo Cecchi 2011-02-23 19:22:50 UTC 
This is fixed in master.