After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599468 - Option for controlling the scaling in printing dialog
Option for controlling the scaling in printing dialog
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: printing
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 602569 (view as bug list)
Depends on: 468989 604258
Blocks:
 
 
Reported: 2009-10-24 08:30 UTC by Adrian Johnson
Modified: 2010-03-15 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Preserve aspect ratio when scaling patch (1.64 KB, patch)
2009-10-24 08:30 UTC, Adrian Johnson
none Details | Review
Preserve aspect ratio when scaling patch (1.38 KB, patch)
2009-10-24 08:38 UTC, Adrian Johnson
committed Details | Review
Add page scaling print option (5.49 KB, patch)
2009-11-25 13:02 UTC, Adrian Johnson
none Details | Review
page scaling tooltip (1.48 KB, patch)
2009-12-05 10:54 UTC, Adrian Johnson
none Details | Review

Description Adrian Johnson 2009-10-24 08:30:35 UTC
Created attachment 146157 [details] [review]
Preserve aspect ratio when scaling patch

Evince scales the document in both the x and y direction to match the printer
page size. The printout would look better if the same scale for the width and
height was used to preserve the aspect ratio. Adobe reader preserves the aspect
ratio when scaling a page to fit.

The attached patch fixes this.

It would be better if there was a user interface option for controlling the
scaling. eg the Adobe reader print dialog has a page scaling combo box with the
options "none"/"fit to printable area"/"shrink to printable area". Scaling to
the printable area would depend on bug 468989.
Comment 1 Adrian Johnson 2009-10-24 08:38:39 UTC
Created attachment 146158 [details] [review]
Preserve aspect ratio when scaling patch

Update patch. The old patch had some extraneous changes.
Comment 2 Carlos Garcia Campos 2009-10-25 12:20:13 UTC
Review of attachment 146158 [details] [review]:

Committed to master and gnome-2-28 branch. Thanks!
Comment 3 Adrian Johnson 2009-11-25 13:02:34 UTC
Created attachment 148439 [details] [review]
Add page scaling print option

The attached patch creates a print dialog custom tab with a page scale combo box that can select between none/shrink to printable area/fit to printable area.

This patch depends on the patches in bug 468989 that expose API for getting the hard margins.
Comment 4 Adrian Johnson 2009-12-05 10:54:18 UTC
Created attachment 149143 [details] [review]
page scaling tooltip

Add tooltip help for the page scaling option.
Comment 5 Carlos Garcia Campos 2009-12-23 17:20:26 UTC
Pushed to git master. I had to appy it manually and I've changed some minor things, so please, review it to make sure I haven't made any mistake.
Comment 6 Marek Kašík 2010-03-15 15:15:10 UTC
*** Bug 602569 has been marked as a duplicate of this bug. ***