After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599213 - Use GtkCellEditable:editing_canceled property instead GTK_ENTRY ()->editing_canceled
Use GtkCellEditable:editing_canceled property instead GTK_ENTRY ()->editing_c...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
2.19.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 594962
Blocks:
 
 
Reported: 2009-10-21 16:26 UTC by Javier Jardón (IRC: jjardon)
Modified: 2009-12-04 01:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GtkCellEditable:editing_canceled property (5.22 KB, patch)
2009-12-04 01:26 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-10-21 16:26:51 UTC 
GtkCellEditable::editing-done property will be added in 2.19 cycle, when this lands, we should also make the code that currently uses entry->editing_canceled directly go through the property
Comment 1 Matthias Clasen 2009-11-28 07:26:09 UTC 
Javier, do you want to work on a patch for this ?
Comment 2 Javier Jardón (IRC: jjardon) 2009-12-04 01:26:23 UTC 
Created attachment 149062 [details] [review]
Use GtkCellEditable:editing_canceled property
Comment 3 Matthias Clasen 2009-12-04 01:36:10 UTC 
Review of attachment 149062 [details] [review]:

If you fix the duplication, it looks good to commit.

::: gtk/gtkcellrenderertext.c
@@ +1735,3 @@
+                "editing-canceled", &canceled,
+                NULL);
+  if (canceled)

No point in getting the same property twice in a row here, or ?
Comment 4 Javier Jardón (IRC: jjardon) 2009-12-04 01:55:01 UTC 
Comment on attachment 149062 [details] [review]
Use GtkCellEditable:editing_canceled property

commit 325bd9299aaf05f18138c7e5f490a9bf9e1ce00a