GNOME Bugzilla – Bug 598235
Login window looses keyboard focus
Last modified: 2010-02-01 18:53:41 UTC
To reproduce. 1. Start GDM greeter 2. Click on the accessibility icon; this brings up the accessibility dialog. 3. Close the dialog. The user list / power buttons no longer have focus. Pressing tab/arrow keys does not bring anything into focus. The cause is the login window has the type hint GDK_WINDOW_TYPE_HINT_DOCK which is causing metacity to not give it focus. This hint is not required as the login window explicity requests no decorations, to be skipped in the taskbar and pager, kept in the background etc.
Created attachment 145326 [details] [review] Removed the DOCK hint from the login window
Review of attachment 145326 [details] [review]: It seems like you may have found the root cause for bug 592183. When we fix this bug we should consider reverting the commit from that bug. ::: gui/simple-greeter/gdm-greeter-login-window.c @@ -1774,3 @@ gtk_window_set_skip_pager_hint (GTK_WINDOW (login_window), TRUE); gtk_window_stick (GTK_WINDOW (login_window)); - gtk_window_set_type_hint (GTK_WINDOW (login_window), GDK_WINDOW_TYPE_HINT_DOCK); GDK_WINDOW_TYPE_HINT_DOCK was added to work around a metacity bug. See bug 587732. If we do revert the TYPE_HINT_DOCK change we should find some other workaround or fix for bug 587732 if it's still applicable.
I think this problem can be fixed if we remove GDK_WINDOW_TYPE_HINT_DOCK with the attachment 145326 [details] [review] , and I agree we need to revert the fix bug 592183. I'm not sure how to reproduce bug #587732.
I'm not seeing bug 587732 occuring in metacity 2.28.0
I reverted the fix for bug #592183 and tried out the patch in comment #2. This does fix the focus problem. Now after exiting the language dialog or the a11y dialog, focus remains in the login window. However, I do see bug #592183 reappear and I do see the ""These windows do not support "save current setup" and will have to be restarted manually next time you log in", referring to Class: Login Window, Window: Gdm-simple-greeter." dialog.
I re-opened bug #587732, since we need to reconsider fixing this issue in metacity.
I mean "However, I do see bug #587732 reappear" in comment #5. Sorry I repeated #592183 incorrectly there.
I have no idea to reproduce bug #587732. I'm not sure if I need to clean up $HOME/.gconf for gdm user. Unfortunately I don't see any error dialogs. However If you need, I can revert the fix of bug 592183.
*** This bug has been marked as a duplicate of bug 59218 ***
*** This bug has been marked as a duplicate of bug 592183 ***