GNOME Bugzilla – Bug 597216
Rewritten xml2po processing
Last modified: 2020-03-03 18:36:25 UTC
Created attachment 144672 [details] [review] Rewritten xml2po processing Here is a partial rewrite of xml processing of xml2po. The goal of this rewrite has been to simplify xml processing. doSerialize has been replaced by traverse_tree, a slightly more elaborated method but which uses recursion at his best, so as to limit ancillary methods. Comments are preserved in output, and tests have been updated accordingly. There are some minor non compatible changes regarding 'placeholder' usage, which should occur slightly less often. Handling of CDATA and pi nodes have been added to the Docbook test.
With the quick look, it seems you are seriously changing the behaviour of placeholder replacements. I'll take a deeper look later today. Note that I've started some rewriting myself, but it's far from complete so far. I'll also be moving xml2po out of gnome-doc-utils soon.
Also, please split out docbook mode changes out of this patch so it can be judged on it's own merit (i.e. "phrase" introduction and such).
I'm glad to know you still have time and interest in xml2po. Great! Now about the split, it makes no sense because the changes in modes are related to the XML processing changes. Feel free to poke me on IRC if you need further explanations.
gnome-doc-utils has been superseded by yelp-xsl, yelp-tools, and itstool. gnome-doc-utils will not see any further development, hence closing as WONTFIX. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/255