After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594199 - GObject-Introspection files fail to build for out-of-tree builds
GObject-Introspection files fail to build for out-of-tree builds
Status: RESOLVED DUPLICATE of bug 604770
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal major
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks: 569778
 
 
Reported: 2009-09-05 07:00 UTC by Sebastian Dröge (slomo)
Modified: 2009-12-18 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Summarized patch according to comment #1 (3.61 KB, patch)
2009-09-15 14:17 UTC, Theppitak Karoonboonyanan
none Details | Review

Description Sebastian Dröge (slomo) 2009-09-05 07:00:53 UTC
Hi,
currently the gobject-introspection files fail to build for out-of-tree builds. This is becase g-ir-scanner gets the source files passed without a path.

To fix this all source files should get $(srcdir) prepended.
Comment 1 Theppitak Karoonboonyanan 2009-09-15 14:13:11 UTC
I also saw this problem. And selectively prepending $(srcdir) to relevant
sources is not trivial, as the list is mixed with built sources like
pango-enum-types.c, which is under $(builddir).

Relying on $^ auto variable is not straightforward, either, as the *.gir
targets depend on various kinds of sources, some of which must be supplied via
command-line option, such as libpango-1.0.la.

So, I ended up with GNU make auto-only prerequisites, like this:

---8<---
Pango-1.0.gir: $(libpango_1_0_la_SOURCES)
Pango-1.0.gir: $(pango_headers)
Pango-1.0.gir: | libpango-1.0.la
Pango-1.0.gir: | $(G_IR_SCANNER) Makefile
        $(AM_V_GEN) $(G_IR_SCANNER) -v --namespace Pango --nsversion=1.0 \
            --add-include-path=$(srcdir) --add-include-path=. \
            ...
            $(PANGO_CFLAGS) \
            $^ \
            pango-enum-types.h
---8<---
Comment 2 Theppitak Karoonboonyanan 2009-09-15 14:17:00 UTC
Created attachment 143230 [details] [review]
Summarized patch according to comment #1
Comment 3 Theppitak Karoonboonyanan 2009-09-15 14:20:26 UTC
(In reply to comment #1)

> So, I ended up with GNU make auto-only prerequisites, like this:

s/auto/order/
Comment 4 Johan (not receiving bugmail) Dahlin 2009-12-18 09:22:51 UTC

*** This bug has been marked as a duplicate of bug 604770 ***